Name scalar based on percentile to report #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, the scalar name would end up as containing the value of the percentile rather than the percentile that we are trying to compute. We then end up with a bunch of one point metrics which clutters the UI and also means we cannot get any information about the actual percentiles. This patch fixes that by actually naming the scalar after the percentile that we are trying to compute.
mtrofin
approved these changes
Mar 31, 2025
svkeerthy
pushed a commit
that referenced
this pull request
Apr 10, 2025
Before this patch, the scalar name would end up as containing the value of the percentile rather than the percentile that we are trying to compute. We then end up with a bunch of one point metrics which clutters the UI and also means we cannot get any information about the actual percentiles. This patch fixes that by actually naming the scalar after the percentile that we are trying to compute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, the scalar name would end up as containing the value of the percentile rather than the percentile that we are trying to compute. We then end up with a bunch of one point metrics which clutters the UI and also means we cannot get any information about the actual percentiles. This patch fixes that by actually naming the scalar after the percentile that we are trying to compute.