Add a -debug flag to enable debug endpoints #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaqx0r
reviewed
May 15, 2020
| @@ -47,6 +47,7 @@ var ( | |||
| dumpAst = flag.Bool("dump_ast", false, "Dump AST of programs after parse (to INFO log).") | |||
| dumpAstTypes = flag.Bool("dump_ast_types", false, "Dump AST of programs with type annotation after typecheck (to INFO log).") | |||
| dumpBytecode = flag.Bool("dump_bytecode", false, "Dump bytecode of programs (to INFO log).") | |||
| debug = flag.Bool("debug", false, "Enable debugging endpoints.") | |||
There was a problem hiding this comment.
Default to true to retain existing behaviour please.
There was a problem hiding this comment.
Also please make the flag be called "http_debugging_endpoint".
jaqx0r
suggested changes
Jun 22, 2020
| @@ -47,6 +47,7 @@ var ( | |||
| dumpAst = flag.Bool("dump_ast", false, "Dump AST of programs after parse (to INFO log).") | |||
| dumpAstTypes = flag.Bool("dump_ast_types", false, "Dump AST of programs with type annotation after typecheck (to INFO log).") | |||
| dumpBytecode = flag.Bool("dump_bytecode", false, "Dump bytecode of programs (to INFO log).") | |||
| debug = flag.Bool("debug", false, "Enable debugging endpoints.") | |||
There was a problem hiding this comment.
Also please make the flag be called "http_debugging_endpoint".
| @@ -79,6 +79,7 @@ type Server struct { | |||
| dumpAst bool // if set, mtail prints the program syntax tree after parse | |||
| dumpAstTypes bool // if set, mtail prints the program syntax tree after type checking | |||
| dumpBytecode bool // if set, mtail prints the program bytecode after code generation | |||
| debug bool // if set, enable debug endpoints | |||
There was a problem hiding this comment.
This variable and it's friends should be called httpDebugEndpoints
| @@ -299,19 +300,23 @@ func (m *Server) Serve() error { | |||
| return errors.Errorf("No bind address provided.") | |||
| } | |||
| mux := http.NewServeMux() | |||
| if m.debug { | |||
| mux.Handle("/", m) | |||
There was a problem hiding this comment.
I think the root handler should remain but we can strip the sensitive information in the template.
| @@ -107,6 +107,12 @@ func DumpBytecode(m *Server) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // Debug enables debug http endpoints | |||
| func Debug(m *Server) error { | |||
|
This PR has been waiting for an update for more than 60 days and wlil be closed in 7 if no update is provided. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would implement #305 but we can surely improve it as I (lazily, I confess) put many different endpoints under the same flag.