-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http_debugging_endpoint and http_info_endpoint flag to allow disabeling http debug endpoints #667
Add http_debugging_endpoint and http_info_endpoint flag to allow disabeling http debug endpoints #667
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
2359e69
to
6accf5c
Compare
Codecov Report
@@ Coverage Diff @@
## main #667 +/- ##
==========================================
- Coverage 56.85% 56.59% -0.26%
==========================================
Files 66 66
Lines 7414 7439 +25
==========================================
- Hits 4215 4210 -5
- Misses 2947 2975 +28
- Partials 252 254 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Benchmark ResultBenchmark diff with base
|
6accf5c
to
aede745
Compare
Could anyone review this ? |
Yep sorry. |
aede745
to
519a5a9
Compare
I incorporated the feedback. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sorry, but I do not know how to fix the remaining CI issues |
Unit Test Results 1 files 27 suites 4m 22s ⏱️ Results for commit 2ce3318. |
Thanks! |
fixes #305
Note: this is just #308 with the feedback incorporated (as the original went stale)