Fix csharp cscvrptw example. Protect callbacks from GC. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Mizux
requested changes
Jan 19, 2018
examples/csharp/cscvrptw.cs
Outdated
| //protect callbacks from the GC | ||
| GC.KeepAlive(manhattan_callback); | ||
| GC.KeepAlive(demand_callback); | ||
| for (int cost_callback_index = 0; cost_callback_index < cost_callbacks.Length; cost_callback_index++) |
There was a problem hiding this comment.
"{" should be at the end on line for consistency
narfunikita
force-pushed
the
fix-csharp-cscvrptw-example-GC
branch
from
b0098bc
to
5073757
Compare
narfunikita
commented
Jan 19, 2018
| //protect callbacks from the GC | ||
| GC.KeepAlive(manhattan_callback); | ||
| GC.KeepAlive(demand_callback); | ||
| for (int cost_callback_index = 0; cost_callback_index < cost_callbacks.Length; cost_callback_index++) { |
There was a problem hiding this comment.
@Mizux Fixed
"{" should be at the end on line for consistenc
Mizux
approved these changes
Jan 20, 2018
Mizux
approved these changes
Jan 20, 2018
GerHobbelt
pushed a commit
to GerHobbelt/or-tools
that referenced
this pull request
May 23, 2024
AT-8842: Fix `go.Dockerfile` for export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we invoke SolveWithParameters of RoutingModel CLR GC can start collecting.
If it's happens, we get exception when callbacks invoked because GC think that delegates won't be used and clear objects.
Exception: CallbackOnCollectedDelegate
A callback was made on a garbage collected delegate of type 'Google.OrTools!Google.OrTools.ConstraintSolver.NodeEvaluator2+SwigDelegateNodeEvaluator2_0::Invoke'. This may cause application crashes, corruption and
data loss. When passing delegates to unmanaged code, they must be kept alive by the managed application until it is guaranteed that they will never be called.
For fix use GC.KeepAlive method.
Here example of this solution with delegates and unmanaged code.
https://msdn.microsoft.com/en-us/library/system.gc.keepalive(v=vs.110).aspx