Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make old experiment validation changes dynamic #25

Closed
priyald17 opened this issue Jul 24, 2013 · 0 comments
Closed

Make old experiment validation changes dynamic #25

priyald17 opened this issue Jul 24, 2013 · 0 comments
Assignees
@priyald17
Labels
Component-Server enhancement Experiments-Creation Priority-High
Milestone
CurrentSprint

Comments

@priyald17
Copy link
Contributor

Code from branch experimentValidation (commits 7349eb4 to fe074a3) (7 commits) already merged into newCreationFlow via develop.

Now, restructure this validation to be dynamic (where possible, done as the user passes through the field).

Includes from before: experiment title, input variable names, start date must not be after end date, list inputs must have at least one list option, email address field validation (admins and published).

New: validation of likert steps (should be a valid nonnegative number)

EDIT: New: validation of timeout (should be a valid nonnegative number)

Master Issue: #63
@ghost ghost assigned priyald17 Jul 24, 2013
priyald17 added a commit that referenced this issue Jul 30, 2013
@priyald17
issue #25 - Adapted old experiment creation validation changes and ma…
9b7e756 
…de them dynamic. Also added validation for likert steps. The new validation model now validates all entities dynamically, and where needed, validates some entities upon experiment submission. TODO: unit testing.
priyald17 added a commit that referenced this issue Jul 30, 2013
@priyald17
issue #25 - moved link to DatePicker ValueChangeEvent bug to the appr…
c9c9aff 
…opriate comment in DurationView.
priyald17 added a commit that referenced this issue Jul 30, 2013
@priyald17
issue #25 - added testing for experiment creation validation. Tests a…
26fbf04 
…re on both the experiment/input model objects and the panels that fire value change events.
@priyald17 priyald17 mentioned this issue Jul 30, 2013
Merged
priyald17 added a commit that referenced this issue Aug 1, 2013
@priyald17
issue #25 - Fixed up code based on code review comments (error-checki…
4f5cb48 
…ng, refactoring, etc.). Added validation for negative numbers on likert. Modified input name validation so it uses a regex rather than just checking for spaces. Added validation for timeout. Fixed date validation bug (fixing late start date by moving it to same day as the end date did not work) by pulling date values from the start and end boxes rather than from value change events.
priyald17 added a commit that referenced this issue Aug 1, 2013
@priyald17
issue #25 - Alphabetized error messages for display. Updated email do…
11f8c58 
…cumentation and tests to indicate that email TLD's such as co.uk are accepted.
priyald17 added a commit that referenced this issue Aug 5, 2013
@priyald17
issue #25: Fixed null pointer exception caused by setting email field…
c39354b 
…s in ExperimentDAO to null while removing sensitive fields.
This was referenced Aug 9, 2013
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@priyald17 priyald17

Labels
Component-Server enhancement Experiments-Creation Priority-High
Projects
None yet
Milestone
CurrentSprint
Development

No branches or pull requests
1 participant
@priyald17