Ios init #207
Ios init #207
Conversation
| @@ -31,58 +31,85 @@ @implementation PacoConsentViewController | |||
| @synthesize experiment = _experiment; | |||
|
|
|||
| + (PacoConsentViewController*)controllerWithExperiment:(PacoExperimentDefinition *)experiment { | |||
| PacoConsentViewController* controller = | |||
| PacoConsentViewController* controller = | |||
There was a problem hiding this comment.
We use 2 spaces as the indent, and use spaces instead of tabs. Please don't change this style. And any new code should follow this style too. You can set up the Xcode by going to Preferences, Text Editing, Indentation, then
a. set "Prefer indent using" to Spaces.
b. set both Tab width and Indent width to 2 spaces.
For detailed coding style, check Google's Objective-C style guide:
http://google-styleguide.googlecode.com/svn/trunk/objcguide.xml
|
Please clean this pull request by using 2 spaces for the indentation. |
| frame.origin.y = 420 - (frame.size.height / 2) - 25; | ||
| accept.frame = frame; | ||
| [super viewDidLoad]; | ||
| if ([self respondsToSelector:@selector(edgesForExtendedLayout)])//for ios7, to adjust layout |
There was a problem hiding this comment.
Although there is only one line in the if-block, it's error-prone to miss the brackets. Please add the brackets:
if ([self respondsToSelector:@selector(edgesForExtendedLayout)]) { //for ios7, to adjust layout
self.edgesForExtendedLayout = UIRectEdgeNone;
}
|
Thanks for the code @dhanya ! |
ghost
assigned | @@ -35,13 +35,13 @@ - (void)application:(UIApplication *)application didReceiveLocalNotification:(UI | |||
| if (notification == nil) { | |||
| return; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Don't commit this kind of change, it's not necessary, and makes the code difficult to review.
#39 and #40 UI fixes