Faster loading change #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uch that schedule params are no longer part of ExperimentDAOCore. This is an initial step in moving to using SignalGroups in the ExperimentDAO.\n Also fixed a bug in ExperimentRetriever, accounting for the fact that an experiement's published property might be null.
| experiment = experimentProviderUtil.getExperiment(uri); | ||
| // } else { | ||
| // experiment = experimentProviderUtil.getExperimentFromDisk(uri); | ||
| // } |
There was a problem hiding this comment.
Oops! I meant to delete the extraneous statements here (since we don't need them for future reference) and will do so after the review.
ghost
assigned 
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: please see my inline github comments. Since there is a lot of copy/paste, these comments draw attention to the important changes (which are hard to sniff out in the diffs).
Changed ExperimentDAOCore such that it no longer includes schedule/signaling params.
This change involved changing the flow on the Android client such that an experiment's full definition is loaded after the user agrees to the Informed Consent Form but before the user schedules the experiment. Thus, there is a lot of copy/paste of code that used to be in ExperimentScheduleActivity into InformedConsentActivity. Also, the MockExperimentProviderUtil previoulsy used in the ExperimentScheduleActivityTest is now available to the InformedConsentActivityTest as well.