Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

Conversation

ktechmidas
Copy link
Contributor

Hi,

This is my first pull request to Google so please be gentle... :) in Python 3.x xrange has been deprecated and removed from more recent versions. range is the same as xrange from Python 2.x

1: https://docs.python.org/3/whatsnew/3.0.html

2: https://stackoverflow.com/a/95100

…om python 2.x and xrange has been deprecated
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@coveralls
Copy link

coveralls commented Oct 15, 2017

Coverage Status

Coverage remained the same at 48.02% when pulling 53bcab0 on ktechmidas:master into e8a6f84 on google:master.

@ktechmidas
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@ktechmidas
Copy link
Contributor Author

I believe you will need to pull #61 before pulling this one to fix the CI.

Copy link
Contributor

@fahhem fahhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Since the number of args should be small, the cost of range() in Python 2 should be small (< 10 elements) so it's not worth doing a version check.

@fahhem fahhem merged commit ed1f7f6 into google:master Oct 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants