Added app uninstallation feature and make -r in installation optional #81
Conversation
MohammadAG
force-pushed
the
uninstall_package
branch
from
9882015 to
4069ff6
Compare
adb/adb_commands.py
Outdated
| return self.Shell('pm install -r "%s"' % destination_path, | ||
| timeout_ms=timeout_ms) | ||
|
|
||
| cmds = ['pm install'] |
There was a problem hiding this comment.
call this cmd since it's only one command. Or args or pieces if you want it plural
adb/adb_commands.py
Outdated
| Returns: | ||
| The pm uninstall output. | ||
| """ | ||
| cmds = ['pm uninstall'] |
|
Done, no clue why I used cmds. |
adb/adb_commands.py
Outdated
| cmd.append('-r') | ||
| cmd.append('"%s"' % destination_path) | ||
|
|
||
| return self.Shell(" ".join(cmd), timeout_ms=timeout_ms) |
There was a problem hiding this comment.
last thing, use ' here to be consistent with quotes
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
Thanks! |
4 participants
No description provided.