This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Fixed console scripts entry points naming clash with android-adb-tools #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with android's existing tool names
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed console scripts entry points to use names that do not conflict with android's existing tool names
Running setup.py develop/install will create binaries in your Python env's bin/ folder which is likely in the user's path. If the user has the normal 'android-adb-tools' installed or simply the android platform-tools folder in their path AND the Python env this package is installed in, this package takes precedent when 'adb' is run. This might break other programs on the system that expect the regular ADB to run.
Fix: Changed the entry points to be 'pyadb' and 'pyfastboot' so the user still has the choice to run normal 'adb' and 'fastboot'. Feel free to change these entry point names to something else if you do not like the prefixes I've chosen.