This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Fixed TypeError in TcpHandle and sign_pythonrsa #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #86
In Python3, using
str
as the type of _buf causesTypeError: Can't convert 'bytes' object to str implicitly
in the newest commit 0b15f4f with python-rsa.And it can be fixed below:
And thanks to @Myonium, the TypeError in TcpHandle can also be resolved.
@fahhem I don't know why this PR cannot be accepted. If you guys don't want to merge this branch, just close it.