Use glslang's new GLSLANG_BUILD_PIC CMake flag #1094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of pushing / popping `CMAKE_CXX_FLAGS` with -fPIC. This reverts "Glslang third party build needs -fPIC (google#1093)"
ben-clayton
force-pushed
the
glslang-build-pic
branch
from
4f36188
to
3ee10e3
Compare
|
Looks like tests need updating for new glslang codegen patterns |
dneto0
approved these changes
Jul 6, 2020
|
Are we landing changes when the presubmits are red? |
|
#1097 will hopefully resolve the build issues. Once it has landed this can be rebased and tried again. |
|
I might abandon this due to: KhronosGroup/glslang#2326 |
|
Superseded with #1098 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of pushing / popping
CMAKE_CXX_FLAGSwith-fPIC.This reverts "Glslang third party build needs -fPIC (#1093)"