Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update collapse arrows on user input summary #7771

Closed
mxbclang opened this issue Oct 25, 2023 · 3 comments
Closed

Update collapse arrows on user input summary #7771

mxbclang opened this issue Oct 25, 2023 · 3 comments
Labels
P1 Medium priority Type: Bug Something isn't working

Comments

@mxbclang
Copy link

mxbclang commented Oct 25, 2023

Feature Description

As reported by @sigal-teller in Bug Bash (Asana task), the Edit arrows in the user input summary (both in the initial setup flow and in Settings) are incorrect:

image

image

These should be updated to match the Figma design:

image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The user input preview group accordions should use a thin caret icon according to the Figma designs instead of the currently used filled chevron icon.

Implementation Brief

The problem is due to CSS applied to all svg within CTA links which sets the fill: currentColor. This is applying the color we want to remove, so setting this to none specifically for these Edit links resolves the issue. This seems to be needed in CSS specifically as setting the attribute in the svg is being overridden by CSS.

Don't remove fill: currentColor from all links, see @tofumatt's comment below: #7771 (comment)

Test Coverage

  • No additions necessary
  • VRT reference images may need updating

QA Brief

  • Ensure the Edit button arrow in the AC has the correct shape (without fill) on hover, focus and click.

Changelog entry

  • Fix bug that caused the "Edit" buttons in Key Metrics Admin Settings to render incorrectly.
@mxbclang mxbclang added P1 Medium priority Type: Enhancement Improvement of an existing feature labels Oct 25, 2023
@nfmohit nfmohit removed their assignment Oct 30, 2023
@aaemnnosttv aaemnnosttv self-assigned this Oct 30, 2023
@aaemnnosttv
Copy link
Collaborator

@nfmohit the icon is actually correct, it's a stylistic bug. AC LGTM, I'll add an IB 👍

@aaemnnosttv aaemnnosttv removed their assignment Oct 30, 2023
@tofumatt tofumatt self-assigned this Oct 31, 2023
@tofumatt
Copy link
Collaborator

tofumatt commented Oct 31, 2023

currentColor is what allows some CTA links with icons to have the icon colour match the text colour, so we shouldn't remove it wholesale. It's odd that this SVG's fill affects that part of the arrow I guess, but we should specifically remove that fill only for these edit links 🤔

I've clarified that in the IB, but seems a fine approach otherwise 👍🏻

IB ✅

@tofumatt tofumatt removed their assignment Oct 31, 2023
@jimmymadon jimmymadon self-assigned this Nov 5, 2023
@jimmymadon jimmymadon added Type: Bug Something isn't working and removed Type: Enhancement Improvement of an existing feature labels Nov 5, 2023
@jimmymadon jimmymadon removed their assignment Nov 5, 2023
@zutigrm zutigrm assigned zutigrm and unassigned zutigrm Nov 6, 2023
@tofumatt tofumatt assigned tofumatt and unassigned tofumatt Nov 6, 2023
@wpdarren wpdarren self-assigned this Nov 7, 2023
@wpdarren
Copy link
Collaborator

wpdarren commented Nov 7, 2023

QA Update: ✅

Verified:

  • The user input preview group accordions use a thin caret icon according to the Figma designs.
  • Tested on desktop and smaller viewports like mobile.
Screenshots

image
image
image
image

@wpdarren wpdarren removed their assignment Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants