In gcc __powerpc64__ not __ppc64__ defines the PPC64 architecture

[grooverdan]

Corrects 18488d6 and still maintains
clang compatibility (like the #27 originally).

Compiler tests:

$ uname -m
ppc64le
$ cat /tmp/x.c

$ gcc -c /tmp/x.c
/tmp/x.c:3:2: warning: #warning powerpc64 exists [-Wcpp]
#warning powerpc64 exists
^~~~~~~
/tmp/x.c:11:2: error: #error ppc64 not defined
#error ppc64 not defined
^~~~~
$ clang /tmp/x.c
/tmp/x.c:3:2: warning: powerpc64 exists [-W#warnings]
^
/tmp/x.c:9:2: warning: ppc64 exists [-W#warnings]
^
2 warnings generated.

I should be on the CLA list already.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[grooverdan]

I signed it!

[googlebot]

CLAs look good, thanks!

[antonblanchard]

Thanks @grooverdan, this fixes the issue for me.

[grooverdan]

reminder - quick compatible with clang fix for gcc users.

[antonblanchard]

Can someone please merge this patch? It's an obvious fix and over a year old.

[cmumford]

@googlebot rescan

[googlebot]

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

[grooverdan]

happy bug day to you 🎂

[pwnall]

@grooverdan I tried to find some docs around this, but everything I found states that both powerpc64 and PPC64 work. I also put together https://godbolt.org/z/cAf6BT which seems to confirm this theory.

Docs:
http://openpowerfoundation.org/wp-content/uploads/resources/leabi/content/dbdoclet.50655243_75216.html
https://www.ibm.com/support/knowledgecenter/en/SS3KZ4_9.0.0/com.ibm.xlcpp9.bg.doc/compiler_ref/platform_related.htm

[pwnall]

Sorry it took so long to look into this. I'll approve the PR with the change below.

[pwnall]

Can you please do #elif defined(__ppc__) || defined(__PPC__)

I think this works as well, and matches what we have in other parts of the codebase, for example: https://github.com/abseil/abseil-cpp/blob/38b704384cd2f17590b3922b97744be0b43622c9/absl/debugging/internal/stacktrace_config.h

[grooverdan]

sorry it took so long. Lost track of this. Suggestion works for me, though will probably defined on ppc32 however it the stubs header is also covered by HAVE_BUILTIN_CTZ (compile checked), and FindMatchLength falls back to portable version.

A test of this: https://travis-ci.org/grooverdan/snappy/builds/600582620

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[pwnall]

I'm really sorry, I completely lost track of this 😢

Based on new data, I plan to fix this problem using the approach here: pwnall@a9955e5