Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Fix for truncating periods with undefined date range. Fixes #413 #414

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

askogvold
Copy link
Contributor

max(0, None) resulted in start_date being set to 0 (integer). This crashed at a later point
when trying to parse the date string 0 (int).
Now explicitly handling None when truncating.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Tests are failing due to a warning that the feed is expired. This extends the feed to 2025,
as a quick fix to the problem.
max(0, None) resulted in start_date being set to 0 (integer). This crashed at a later point
when trying to parse the date string 0 (int).
Now explicitly handling None when truncating.
@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants