Ignore non-zero exit code from clang-format --version #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make version check logic a little more explicit and fix quirks for empty version or comparing shorter versions. Fixes #84.
agriffis
approved these changes
Apr 1, 2020
| return 0 | ||
| endif | ||
| " Compare each dotted version value in turn. | ||
| let l:length = max([len(a:minimum_version), len(s:clang_format_version)]) |
There was a problem hiding this comment.
intentional change from min to max?
There was a problem hiding this comment.
ah, I see the change in the loop below, nevermind
| return 0 | ||
| endif | ||
| endfor | ||
| return len(a:minimum_version) <= len(s:clang_format_version) | ||
| " All version numbers were equal, so version was at least minimum. | ||
| return 1 |
There was a problem hiding this comment.
this version comparison code feels like something that would be useful as a general helper, eventually
There was a problem hiding this comment.
For sure. We do have something similar in maktaba#IsAtLeastVersion, but without the variable length.
OTOH, often code that's checking versions is also low-level code that's awkward to have depending on libraries, but doesn't hurt to make an implementation available, at any rate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make version check logic a little more explicit and fix quirks for empty version or comparing shorter versions.
Resolves a ShellError bug when invoking some versions of the clang-format tool that return non-zero exit code, and instead makes it so if the tool returns a parseable version number it will be used regardless of exit code.
The material change was just updating
.Call()to.Call(0), but I refactored the version check logic a little in the process to make sure the scenario of empty version number is handled properly. Also adjusts the logic for comparing versions of mismatched lengths to pad version with zeros instead of checking length only, which could false negative on long min version values.Fixes #84 .