This repository was archived by the owner on Nov 9, 2022. It is now read-only.
Modernize selector #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the selector window with the changes to maktaba. See: https://github.com/google/vim-maktaba/blob/master/autoload/maktaba/selector.vim
dbarnett
reviewed
May 27, 2020
| @@ -1,4 +1,4 @@ | |||
| selector is a utility to help plugin authors launch a window to choose one of | |||
| # selector is a utility to help plugin authors launch a window to choose one of | |||
There was a problem hiding this comment.
Is this "#" intentional? I think that turns it into a title, not commented out.
| @@ -12,34 +12,18 @@ | |||
| " See the License for the specific language governing permissions and | |||
| " limitations under the License. | |||
|
|
|||
| "" | |||
| " @section Introduction, intro | |||
There was a problem hiding this comment.
Should still have some kind of intro section, shouldn't it? The maktaba file won't have one because it would conflict with maktaba's own intro.
What edits do these source file changes write into the generated docs?
dbarnett
approved these changes
May 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the selector window with the changes to maktaba.
See: https://github.com/google/vim-maktaba/blob/master/autoload/maktaba/selector.vim