-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RangeError: Maximum call stack size exceeded #649
Comments
I've the same problem. On windows and debian. |
The same problem using current master 42350b1.
|
Happening to me aswell. Its happening because of the gulp html task. If i comment out
everything seems to work fine. Guess there's no minified html files till theres a fix. :) |
We've been evolving the build process in the material-sprint branch for our next version. Can someone verify if you experience these issues with html minification there too? |
Will do and post the results here. :) |
i've tried with material-sprint branch. First, i've : i've run (as root) :
gulp serve works perfectly.
i've
Like with the master branch. |
Same issue with the material branch and commenting out the html minification, everything works fine. |
Modifying minifyHtml .pipe in gulpfile.js to read
or
instead of
solves the issue and builds dist fine, but I am not certain if it is proper way to minify html with this gulp.task |
It does solve the error part but um isn't html minify supposed to squeeze all the text together and remove all comments and stuff like it does for the css and js?? |
It does solve the error. but there are no html minify. |
On the second try, the issue is not caused by the minify pipe and it works as expected. The styleguide.html file is the problem and if removed from the /app everything builds fine with minified html files in /build (index.htm, basic.html, etc) . I still did not narrow down what causes the issue in styleguide.html, but file definitely causes RangeError issue |
The mess starts below and it builds well without those sections, but there are issues in multiple places thereafter. |
This workaround works for me: sudo node --stack-size=32000 ./node_modules/gulp/bin/gulp |
@singuerinc, that's a pretty dangerous workaround and doesn't provide a permanent solution to the problem. There's a much, much better way to minify HTML in Gulp, the right way. Forcing a higher stack size is likely to make node unresponsive, especially when it's applied globally to your Gulp module. |
The workarounds mentioned in this bug so far are unfortunately not sufficient to enable us to filter down all the Investigating further. |
I had the same problem. |
Tracing back, it seems like the stack size overflow issues narrow down to gulpjs/vinyl-fs#14 and nodejs/node-v0.x-archive@6820054. Can you verify that you're using Node 0.12 or above and not an older version? |
Here is a bit more to add: |
+1 |
Tried the fix from @artifactsauce but am now getting this error:
|
I'm also getting Maximum call stack size exceeded
Stack ...
Obviously this is could be a red herring. However, here's the stack ref... https://github.com/caolan/async/blob/master/lib/async.js#L265-276 // reduce only has a series version, as doing reduce in parallel won't
// work in many situations.
async.reduce = function (arr, memo, iterator, callback) {
async.eachSeries(arr, function (x, callback) {
iterator(memo, x, function (err, v) {
memo = v;
callback(err);
});
}, function (err) {
callback(err, memo);
});
}; |
gulp serve works fine for me... but gulp alone throws.. events.js:85 So I'm having the same issue... first build of wsk-0.5.2 on Linux mint |
@garyterry Mashinista's response about modifying the gulpfile html solves the problem but it won't minify the html. You'll get the dist but not the minification. |
@addyosmani Trimming To be sure, I tested the task against a single new html file. Here are the results:
So, it must have something to do with parsing a certain number of elements. |
Versions:
Looking a little more into this. |
Thanks for investigating @levithomason. I wouldn't have thought our node counts would cause any of the tooling to choke, but given the number of folks running into this it's definitely something we want to nail down. Just to confirm with anyone that hasn't already: disabling HTML minification atm is allowing you to workaround this issue - is that correct? I'll continue exploring upstream minification issues. Sure others have run into this before (at least, I hope!). |
@addyosmani Yes, I had another error that followed it in relation to images not copying over, which was resolved from #579 |
I'm having this issue as well, I can't seem to figure out what's causing it or how to get around it. At this point I'm going to have to stop using WSK which is really unfortunate. |
I've been testing the wsk-0.5.3 build on win7 and this is what I've found so far...
Before doing anything to fix this, (for once) I simply tried running npm install again... D:\dev.server\test-wsk-0.5.3>gulp and it fails... and run $gulp again... D:\dev.server\test-wsk-0.5.3>gulp and gulp builds clean, So as a final test I run... So I've got a build working... mostly, but it's not copying over images and icons properly... everything else seems fine (ie. minify html works). I'm currently running checks to see if anything else is missing in $gulp serve:dist process. I'll try and replicate this on Linux Mint tonight. Will advise. |
This issue should be caused by new version of
And delete node_modules, then do |
Such a simple fix, DOH! |
If it's possible to get verification from 1-2 more folks that the fix suggested by @ueqt addresses this, I'll get a new release out with that patch in there asap. |
Thx for that solution, now its building successful (serve and serve:dist) (Win7 - 64 bit).
|
Using exact versions works for me:
|
Thanks @ueqt, this works for me. Everthing's ok now. |
@ueqt this solved the issues with the 0.5.2 build too. |
The latest tagged version includes this fix: https://github.com/google/web-starter-kit/releases |
fixed with 0.5.4 |
I am getting rangeerror in events.js when using gulp to build /dist. Any ideas. Thanks
Finished 'jshint' after 1.23 s
events.js:72
throw er; // Unhandled 'error' event
^
RangeError: Maximum call stack size exceeded
The text was updated successfully, but these errors were encountered: