Add standalone flag for logic tests #5
Conversation
Under Xcode 11 Beta 5 this is required
|
I'm not sure when |
test_runner/logic_test_util.py
Outdated
| 'xcrun', 'simctl', 'spawn', sim_id, | ||
|
|
||
| command = ['xcrun', 'simctl', 'spawn'] | ||
| if xcode_info_util.GetXcodeVersionNumber() >= 1100: |
There was a problem hiding this comment.
does it need this version check? i.e. would it behave same way on previous xcodes?
There was a problem hiding this comment.
Maybe not, and I'm not sure what version the --standalone flag was introduced. If we try to run with --standalone on a version before the flag was supported, then it might cause an error.
Let me know if you'd like to just remove the version check and I'll revert 👍
There was a problem hiding this comment.
Based on the slack conversation it sounds like you don't need this check because this existed before too
test_runner/logic_test_util.py
Outdated
|
|
||
| command = ['xcrun', 'simctl', 'spawn'] | ||
| if xcode_info_util.GetXcodeVersionNumber() >= 1100: | ||
| command.extend('--standalone') |
There was a problem hiding this comment.
| command.extend('--standalone') | |
| command.append('--standalone') |
There was a problem hiding this comment.
Will update if we decided to leave the version check
This reverts commit f3d8aae.
Under Xcode 11 Beta 5 this is required