-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: patch default shell on win32 #458
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
When using |
So what is preferable shell on win? cmd.exe? What happens in running script within WSL? |
On windows, the defaults.shell will be true, make node.js decide which shell to run. Normally it's |
It also will be cool to add test for this. Which only runs on win32 and add a GitHub workflow (on Win machine) to test this use case. Can you, please, add such test&workflow? |
Ok, I'll implement the tests later. |
Ok. Win32 specific test implemented and validated both locally & on gh actions. |
`yarn install` currently fails due to two issues: a) several build scripts use "cd some_dir && yarn ...", which is not valid in cmd.exe. Replace with "yarn --cwd some_dir .." b) zx is somehow defaulting to bash, which finds WSL and runs the script in the WSL instance. Supposedly this was fixed in google/zx#458, not sure why it's not working even if I upgrade zx.
Fixes #398