Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal/testing/sample): add package #1508

Merged
merged 2 commits into from
May 13, 2024

Conversation

julieqiu
Copy link
Member

@julieqiu julieqiu commented May 11, 2024

Package sample is added, which provides sample values for use in tests.

The intent is to make it easier to reason about the various test cases,
by using one example and explaining where various values are defined,
using bigquery as an example.

As a starting point, TestGenSnippetFile has been refactor to use the
constants in internal/testing/sample, instead of hardcoding values in
the tests. Other tests will be refactored in follow up PRs.

@julieqiu julieqiu force-pushed the organizeex branch 6 times, most recently from 4ff7d68 to 2b4c121 Compare May 11, 2024 18:18
@julieqiu julieqiu marked this pull request as ready for review May 11, 2024 18:21
@julieqiu julieqiu requested review from a team as code owners May 11, 2024 18:21
@julieqiu julieqiu changed the title internal/testing/sample: add package chore(internal/testing/sample): add package May 11, 2024
@julieqiu julieqiu force-pushed the organizeex branch 2 times, most recently from ded1237 to c7ffdb1 Compare May 11, 2024 18:55
Package sample is added, which provides sample values for use in tests.

The intent is to make it easier to reason about the various test cases,
by using one example and explaining where various values are defined,
using bigquery as an example.

As a starting point, TestGenSnippetFile has been refactor to use the
constants in internal/testing/sample, instead of hardcoding values in
the tests. Other tests will be refactored in follow up PRs.
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool. Love the idea, thanks @julieqiu

@noahdietz noahdietz merged commit 320b85d into googleapis:main May 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants