Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gapic: use DefaultEndpoint and DefaultMTLSEndpoint for default options #465

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

andyrzhao
Copy link
Contributor

The option "WithEndpoint" is intended for user override only, and specifying it will interfere with mTLS endpoint selection. See details regarding mTLS at https://google.aip.dev/auth/4114

The option "WithEndpoint" is intended for user override only, and
specifying it will interfere with MTLS endpoint selection.
@andyrzhao andyrzhao requested a review from a team as a code owner October 21, 2020 19:25
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 21, 2020
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd like @codyoss to review/approve as well.

Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahdietz noahdietz merged commit b836bb6 into googleapis:master Oct 21, 2020
gcf-merge-on-green bot pushed a commit to googleapis/google-cloud-go that referenced this pull request Oct 21, 2020
Updates `gapic-generator-go` to `v0.15.3`. Notable changes include:

* use DefaultEndpoint and DefaultMTLSEndpoint for default options (googleapis/gapic-generator-go#465)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants