-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add fail index to streaming sequence #1364
Conversation
34c6056
to
30f0edc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to include the generated code changes in this PR. They should be automatically included in CI for testing, then contributed back via an automatic PR upon merge.
|
||
|
||
int32 fail_index = 2 [ | ||
(google.api.resource_reference).type = "showcase.googleapis.com/Sequence", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noahdietz Is this a valid resource reference? I think the field reference another resource should be of String type per AIP-122, also the Sequence resource is of pattern sequences/{sequence}
which seems do not fit here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah definitely not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! I accepted Noah's suggestion which iiuc just removed what used to be line 30 with this reference type. I added a clarifying comment, good call @blakeli0. I want to make sure I'm interpreting these comments and the code suggestion from @noahdietz correctly though - do I not need to include a resource type at all? Or, should I be linking to something like
string content = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, not necessary. The resource here is the Sequence being attempted. The content
is just data.
e318526
to
0dcdadb
Compare
Gal was working on this before he moved to another team and I am opening this to make sure I tie up loose ends by finishing his work. I added a test and then I regenerated the support files because of the proto change. It seemed to regenerate more than just my service, but I removed anything unrelated to sequence. If I should re-include those, let me know. cc @galz10