Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check credentials types before using them. #12

Merged
merged 1 commit into from
Jun 6, 2014

Conversation

craigcitro
Copy link
Contributor

We previously used methods from oauth2client.client.GoogleCredentials on an
object that might only be an instance of oauth2client.client.Credentials.

PTAL @orestica

We previously used methods from oauth2client.client.GoogleCredentials on an
object that might only be an instance of oauth2client.client.Credentials.
@orestica
Copy link
Contributor

orestica commented Jun 6, 2014

LGTM.

Thank you for taking care of this, Craig.

On Fri, Jun 6, 2014 at 9:51 AM, Craig Citro notifications@github.com
wrote:

We previously used methods from oauth2client.client.GoogleCredentials on an
object that might only be an instance of oauth2client.client.Credentials.

PTAL @orestica https://github.com/orestica

You can merge this Pull Request by running

git pull https://github.com/craigcitro/google-api-python-client interface

Or view, comment on, or merge it at:

#12
Commit Summary

  • Check credentials types before using them.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#12.

Orest Bolohan

Software Engineer
Cloud/TI Identity and Access Management Services
Google Inc.
Mountain View, CA

(650) 214 3458
orest@google.com

craigcitro added a commit that referenced this pull request Jun 6, 2014
Check credentials types before using them.
@craigcitro craigcitro merged commit 5a86027 into googleapis:master Jun 6, 2014
@craigcitro craigcitro deleted the interface branch October 2, 2014 22:02
akrherz pushed a commit to akrherz/google-api-python-client that referenced this pull request Apr 1, 2019
Add support for Google Default Credentials.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants