Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(testing): switch deprecated WithInsecure to WithTransportCredentials #10091

Merged
merged 1 commit into from
May 2, 2024

Conversation

mark-adams
Copy link
Contributor

The public GRPC docs mention the following with regards to grpc.WithInsecure:

Deprecated: use WithTransportCredentials and insecure.NewCredentials() instead. Will be supported throughout 1.x.

This change updates the example to use WithTransportCredentials() along with insecure.NewCredentials() instead of the deprecated option.

@mark-adams mark-adams requested a review from a team as a code owner May 2, 2024 21:14
Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this!

@noahdietz noahdietz changed the title Update testing.md to remove deprecated WithInsecure GRPC dial option docs(testing): switch deprecated WithInsecure to WithTransportCredentials May 2, 2024
@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label May 2, 2024
Copy link

conventional-commit-lint-gcf bot commented May 2, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@noahdietz noahdietz added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit and removed automerge Merge the pull request once unit tests and other checks pass. labels May 2, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 2, 2024
@noahdietz noahdietz added automerge Merge the pull request once unit tests and other checks pass. and removed automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels May 2, 2024
…PC dial option

The public [GRPC docs](https://pkg.go.dev/google.golang.org/grpc#WithInsecure) mention the following with regards to `grpc.WithInsecure`:

> Deprecated: use WithTransportCredentials and insecure.NewCredentials() instead. Will be supported throughout 1.x.

This change updates the example to use `WithTransportCredentials()` along with `insecure.NewCredentials()` instead of the deprecated option.
@mark-adams
Copy link
Contributor Author

Updated the commit to match conventional commits styling 🤞

@noahdietz
Copy link
Contributor

Updated the commit to match conventional commits styling 🤞

Thanks !

When we use the automerge label, or when there are multiple commits, the bot uses the PR title as the squashed commit message, so there isn't a need to force a new commit to fix it. That said, observing our best practices is appreciated :)

@noahdietz noahdietz added automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit and removed automerge Merge the pull request once unit tests and other checks pass. labels May 2, 2024
@noahdietz noahdietz added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 2, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 2, 2024
@mark-adams
Copy link
Contributor Author

@noahdietz Ah, good to know! Thanks!

@gcf-merge-on-green gcf-merge-on-green bot merged commit 2b576ab into googleapis:main May 2, 2024
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label May 2, 2024
gcf-merge-on-green bot pushed a commit that referenced this pull request May 8, 2024
🤖 I have created a release *beep* *boop*
---


## [0.113.0](https://togithub.com/googleapis/google-cloud-go/compare/v0.112.2...v0.113.0) (2024-05-08)


### Features

* **civil:** Add Compare method to Date, Time, and DateTime ([#10010](https://togithub.com/googleapis/google-cloud-go/issues/10010)) ([34455c1](https://togithub.com/googleapis/google-cloud-go/commit/34455c15d62b089f3281ff4c663245e72b257f37))


### Bug Fixes

* **all:** Bump x/net to v0.24.0 ([#10000](https://togithub.com/googleapis/google-cloud-go/issues/10000)) ([ba31ed5](https://togithub.com/googleapis/google-cloud-go/commit/ba31ed5fda2c9664f2e1cf972469295e63deb5b4))
* **debugger:** Add internaloption.WithDefaultEndpointTemplate ([3b41408](https://togithub.com/googleapis/google-cloud-go/commit/3b414084450a5764a0248756e95e13383a645f90))
* **internal/aliasfix:** Handle import paths correctly ([#10097](https://togithub.com/googleapis/google-cloud-go/issues/10097)) ([fafaf0d](https://togithub.com/googleapis/google-cloud-go/commit/fafaf0d0a293096559a4655ea61062cb896f1568))
* **rpcreplay:** Properly unmarshal dynamic message ([#9774](https://togithub.com/googleapis/google-cloud-go/issues/9774)) ([53ccb20](https://togithub.com/googleapis/google-cloud-go/commit/53ccb20d925ccb00f861958d9658b55738097dc6)), refs [#9773](https://togithub.com/googleapis/google-cloud-go/issues/9773)


### Documentation

* **testing:** Switch deprecated WithInsecure to WithTransportCredentials ([#10091](https://togithub.com/googleapis/google-cloud-go/issues/10091)) ([2b576ab](https://togithub.com/googleapis/google-cloud-go/commit/2b576abd1c3bfca2f962de0e024524f72d3652c0))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants