-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add virtual hosted-style support for signurl gen. #6183
Add virtual hosted-style support for signurl gen. #6183
Commits on Sep 3, 2019
-
Add virtual hosted-style support for signurl gen.
Adds new methods to produce a SignUrlOption that results in generated signed URLs using virtual-hosted-style URLs (i.e. mybucket.storage.googleapis.com instead of storage.googleapis.com/mybucket). One option allows specifying the virtual hostname explicitly (for the case where someone might have a custom subdomain, with a bucket of the same name, CNAME'd to c.storage.googleapis.com), while the other will implicitly construct the hostname using the bucket from the passed-in BlobInfo. Addresses part of https://issuetracker.google.com/issues/130190655.
Configuration menu - View commit details
-
Copy full SHA for e112b08 - Browse repository at this point
Copy the full SHA e112b08View commit details
Commits on Sep 12, 2019
-
Add
withPathStyle()
method for new SignUrlOption.This allows creating a signed URL in path-style (bucket in the path component of the URI instead of in the hostname, i.e. virtual hosted-style). Note that this was already the default behavior, but adding this method allows us to more easily switch the default behavior in the future; virtual hosted-style is considered best practice.
Configuration menu - View commit details
-
Copy full SHA for c91d831 - Browse repository at this point
Copy the full SHA c91d831View commit details
Commits on Sep 16, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 34bef2c - Browse repository at this point
Copy the full SHA 34bef2cView commit details
Commits on Sep 20, 2019
-
Remove unnecessary override, rename methods.
Per code review comments.
Configuration menu - View commit details
-
Copy full SHA for 1517686 - Browse repository at this point
Copy the full SHA 1517686View commit details
Commits on Sep 24, 2019
-
Correctly populate+sign host header for sigV4 URLs
The Signature V2 doesn't require us to sign the "host" header, but the Signature V4 process requires it. We need to ensure we're populating and signing the same host header value as is used in the request URL.
Configuration menu - View commit details
-
Copy full SHA for 95787a2 - Browse repository at this point
Copy the full SHA 95787a2View commit details
Commits on Sep 26, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 41252dd - Browse repository at this point
Copy the full SHA 41252ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f29d2f - Browse repository at this point
Copy the full SHA 0f29d2fView commit details -
Add tests for withVirtualHostedStyle, fix bug.
I discovered a bug with one of my previous commits, where I was incorrectly determining whether to use Signature Version 2. This commit makes two new (private) methods that determine the correct default option to use, taking default values into account.
Configuration menu - View commit details
-
Copy full SHA for 4cda395 - Browse repository at this point
Copy the full SHA 4cda395View commit details
Commits on Sep 30, 2019
-
Configuration menu - View commit details
-
Copy full SHA for fc6e31e - Browse repository at this point
Copy the full SHA fc6e31eView commit details