Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add virtual hosted-style support for signurl gen. #6183

Merged
merged 9 commits into from
Oct 1, 2019
Merged

Add virtual hosted-style support for signurl gen. #6183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e112b08
Add virtual hosted-style support for signurl gen.
houglum Aug 9, 2019
c91d831
Add `withPathStyle()` method for new SignUrlOption.
houglum Sep 12, 2019
34bef2c
Run code formatter.
houglum Sep 16, 2019
1517686
Remove unnecessary override, rename methods.
houglum Sep 20, 2019
95787a2
Correctly populate+sign host header for sigV4 URLs
houglum Sep 24, 2019
41252dd
Also change the method names in the docstrings
houglum Sep 26, 2019
0f29d2f
Update docs with examples.
houglum Sep 26, 2019
4cda395
Add tests for withVirtualHostedStyle, fix bug.
houglum Sep 26, 2019
fc6e31e
Add example URL to docstring.
houglum Sep 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ud-clients/google-cloud-storage/src/main/java/com/google/cloud/storage/SignatureInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ private SignatureInfo(Builder builder) {
this.accountEmail = builder.accountEmail;
this.timestamp = builder.timestamp;

// The "host" header only needs to be present and signed if using V4.
if (Storage.SignUrlOption.SignatureVersion.V4.equals(signatureVersion)
&& (!builder.canonicalizedExtensionHeaders.containsKey("host"))) {
canonicalizedExtensionHeaders =
Expand Down