Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vision: support image URLs #1240

Merged
merged 1 commit into from
May 2, 2016

Conversation

stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Apr 18, 2016

Fixes #1239

Docs: http://stephenplusplus.github.io/gcloud-node/#/docs/master/vision?method=detect

To Dos

  • Docs
  • Tests
    • System
    • Unit

This change will allow our Vision API to accept image URLs.

vision.detectLogos('http://google.com/logo.png', function(err, logos) {
  logos = ['Google']
});

@stephenplusplus stephenplusplus added the api: vision Issues related to the Cloud Vision API. label Apr 18, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 18, 2016
@stephenplusplus stephenplusplus added don't merge and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 18, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 99.716% when pulling c0f5573 on stephenplusplus:spp--1239 into 5199cad on GoogleCloudPlatform:master.

@jgeewax
Copy link
Contributor

jgeewax commented Apr 18, 2016

Is this supported? I thought it was just GCS URLs?

@stephenplusplus
Copy link
Contributor Author

It's not supported by the Vision API. We just do a GET on the URL, get a base64 string of the contents, and pass that to Vision to be annotated.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 18, 2016
@jgeewax
Copy link
Contributor

jgeewax commented Apr 18, 2016

Gotcha - can we make sure that's documented?

@stephenplusplus
Copy link
Contributor Author

Definitely!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9eb59db on stephenplusplus:spp--1239 into 5771373 on GoogleCloudPlatform:master.

@stephenplusplus
Copy link
Contributor Author

@callmehiphop ready for your review, sir.

uri: image,
encoding: 'base64'
}, function(err, resp, body) {
if (err) {

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@coveralls
Copy link

coveralls commented Apr 30, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 25f56bf on stephenplusplus:spp--1239 into e9e4170 on GoogleCloudPlatform:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants