-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vision: support image URLs #1240
Conversation
Is this supported? I thought it was just GCS URLs? |
It's not supported by the Vision API. We just do a |
Gotcha - can we make sure that's documented? |
Definitely! |
c0f5573
to
9eb59db
Compare
@callmehiphop ready for your review, sir. |
uri: image, | ||
encoding: 'base64' | ||
}, function(err, resp, body) { | ||
if (err) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
9eb59db
to
25f56bf
Compare
Fixes #1239
Docs: http://stephenplusplus.github.io/gcloud-node/#/docs/master/vision?method=detect
To Dos
This change will allow our Vision API to accept image URLs.