datastore: fixing a query limit bug #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callmehiphop
added
type: bug
googlebot
added
the
cla: yes
|
LGTM. Is there a test case we can add to cover the situation caused in #1249? |
|
@stephenplusplus I think this would obviously be difficult for us to reproduce via e2e tests, so I'll write a unit test. |
|
@stephenplusplus PTAL! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1249
Since migrating to v1beta3 we've changed the way we store the
limitvalue, this causes a bug if the user did not set a query limit when retrieving a large number of results.