Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: implement retry strategy for grpc requests #1272

Closed
wants to merge 1 commit into from
Closed

core: implement retry strategy for grpc requests #1272

wants to merge 1 commit into from

Conversation

callmehiphop
Copy link
Contributor

Closes #1265

This adds a retry with backoff strategy for gRPC requests. Currently it will only attempt to retry for gRPC error code 14 (service unavailable).

@heidmotron @leonardpunt @jmdobry if any of you would like to test if this resolves your issues, that would be awesome :)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 28, 2016
@stephenplusplus
Copy link
Contributor

Is it possible to use retry request directly? It accepts a custom request function. If it's close, but kind of a hack, maybe it just needs a pr to generalize it.

@callmehiphop
Copy link
Contributor Author

I initially did go down this route but it started to get pretty hacky, so I gave up on it. However if you think a PR there is the way to go, I'd be more than happy to try and tackle that.

@stephenplusplus
Copy link
Contributor

If it's possible without getting into hack territory, I think that would be awesome.

@coveralls
Copy link

coveralls commented Apr 28, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 072602b on callmehiphop:grpc-retry-requests into e9e4170 on GoogleCloudPlatform:master.

@coveralls
Copy link

coveralls commented Apr 28, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 072602b on callmehiphop:grpc-retry-requests into e9e4170 on GoogleCloudPlatform:master.

@heidmotron
Copy link

@callmehiphop this works, thanks!

@callmehiphop
Copy link
Contributor Author

Closing in favor of #1273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

503 unavailable response from datastore after app has idled for a few minutes
5 participants