Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription#new add option maxInProgress #649

Closed
wants to merge 12 commits into from
Closed

Subscription#new add option maxInProgress #649

wants to merge 12 commits into from

Conversation

leibale
Copy link
Contributor

@leibale leibale commented Jun 9, 2015

Subscription#new add option maxInProgress (to make sure the application working on {Number} messages in parallel)

dov_eidelman added 2 commits June 9, 2015 16:39
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 9, 2015
@leibale
Copy link
Contributor Author

leibale commented Jun 9, 2015

i fixed the "cla/google — Need a CLA for one or more commit authors" issue,
about the "The Travis CI build failed"- i don't know what is it..

@leibale leibale closed this Jun 9, 2015
@leibale leibale reopened this Jun 9, 2015
@leibale
Copy link
Contributor Author

leibale commented Jun 9, 2015

why the CLA issue not resolve?

@jgeewax
Copy link
Contributor

jgeewax commented Jun 9, 2015

Looks like the commits are authored by dov_eidelman... If you authored the commits, you need to set the e-mail address to be your GitHub e-mail address. See http://stackoverflow.com/questions/3042437/change-commit-author-at-one-specific-commit for help on amending previous commits to update the true author.

@leibale
Copy link
Contributor Author

leibale commented Jun 9, 2015

now the commit are authored by "leibale" but the pull request still with "cla:no" label

@stephenplusplus
Copy link
Contributor

Thanks @leibale! I'm going to implement this functionality in a new PR to address some styling issues. I'll ping you over when it's ready to take a look, and hopefully you can check it out and make sure it still works for you.

@leibale
Copy link
Contributor Author

leibale commented Jun 9, 2015

ok :)

@stephenplusplus stephenplusplus mentioned this pull request Jun 9, 2015
2 tasks
@stephenplusplus
Copy link
Contributor

Closed in favor of #650

sofisl pushed a commit that referenced this pull request Nov 10, 2022
fix: use google-gax v3.3.0
Source-Link: googleapis/synthtool@c73d112
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
sofisl added a commit that referenced this pull request Nov 11, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants