Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): un-deprecate resource name helper functions, add 3.8 tests (via synth) #10062

Merged
merged 2 commits into from Jan 30, 2020

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Jan 7, 2020

This PR was generated using Autosynth. 🌈

Log from Synthtool
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/spanner/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:264654a37596a44b0668b8ce6ac41082d713f6ee150b3fc6425fa78cc64e4f20
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/spanner/artman_spanner.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/mutation.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/mutation.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/spanner.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/spanner.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/type.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/type.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/keys.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/keys.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/result_set.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/result_set.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/transaction.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/transaction.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/query_plan.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/query_plan.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto.
synthtool > Replaced 'import google.api_core.grpc_helpers\n' in google/cloud/spanner_v1/gapic/transports/spanner_grpc_transport.py.
synthtool > Replaced 'from google.cloud.spanner_v1.proto import spanner_pb2_grpc\n' in google/cloud/spanner_v1/gapic/transports/spanner_grpc_transport.py.
synthtool > Replaced '(\\s+)return google.api_core.grpc_helpers.create_channel\\(\n' in google/cloud/spanner_v1/gapic/transports/spanner_grpc_transport.py.
synthtool > Replaced 'from google.cloud import spanner_v1' in tests/unit/gapic/v1/test_spanner_client_v1.py.
synthtool > Running generator for google/spanner/admin/instance/artman_spanner_admin_instance.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-instance-v1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/admin/instance/v1/spanner_instance_admin.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-instance-v1/google/cloud/spanner_admin_instance_v1/proto/spanner_instance_admin.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-instance-v1/google/cloud/spanner_admin_instance_v1/proto.
synthtool > Replaced "'google-cloud-spanner-admin-instance'" in google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client.py.
synthtool > Replaced 'from google\\.cloud\\.spanner\\.admin\\.instance_v1.proto' in google/cloud/spanner_admin_instance_v1/proto/spanner_instance_admin_pb2_grpc.py.
synthtool > Replaced '====*' in google/cloud/spanner_v1/proto/transaction_pb2.py.
synthtool > Replaced '----*' in google/cloud/spanner_v1/proto/transaction_pb2.py.
synthtool > Replaced '~~~~*' in google/cloud/spanner_v1/proto/transaction_pb2.py.
synthtool > Running generator for google/spanner/admin/database/artman_spanner_admin_database.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-database-v1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/admin/database/v1/spanner_database_admin.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-database-v1/google/cloud/spanner_admin_database_v1/proto/spanner_database_admin.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-database-v1/google/cloud/spanner_admin_database_v1/proto.
synthtool > Replaced "'google-cloud-spanner-admin-database'" in google/cloud/spanner_admin_database_v1/gapic/database_admin_client.py.
synthtool > Replaced 'from google\\.cloud\\.spanner\\.admin\\.database_v1.proto' in google/cloud/spanner_admin_database_v1/proto/spanner_database_admin_pb2_grpc.py.
synthtool > Replaced '"""Attributes:' in google/cloud/spanner_admin_instance_v1/proto/spanner_instance_admin_pb2.py.
.coveragerc
.flake8
MANIFEST.in
docs/_static/custom.css
docs/_templates/layout.html
noxfile.py.j2
setup.cfg
synthtool > Replaced 'include README.rst LICENSE\n' in MANIFEST.in.
Running session blacken
Creating virtual environment (virtualenv) using python3.6 in .nox/blacken
pip install black==19.3b0
black docs google tests noxfile.py setup.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_database_v1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_database_v1/gapic/database_admin_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_database_v1/gapic/transports/database_admin_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_instance_v1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_database_v1/proto/spanner_database_admin_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_instance_v1/gapic/transports/instance_admin_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_database_v1/gapic/database_admin_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_instance_v1/proto/spanner_instance_admin_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_database_v1/proto/spanner_database_admin_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/gapic/spanner_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/gapic/transports/spanner_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/keys_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/keys_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/mutation_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/gapic/spanner_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/query_plan_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/mutation_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/result_set_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/query_plan_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_admin_instance_v1/proto/spanner_instance_admin_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/result_set_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/transaction_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/spanner_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/type_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/type_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/transaction_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/noxfile.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/tests/unit/gapic/v1/test_database_admin_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/tests/unit/gapic/v1/test_instance_admin_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/tests/unit/gapic/v1/test_spanner_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/spanner/google/cloud/spanner_v1/proto/spanner_pb2.py
All done! ✨ 🍰 ✨
34 files reformatted, 54 files left unchanged.
Session blacken was successful.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: spanner label Jan 7, 2020
@googlebot googlebot added the cla: yes label Jan 7, 2020
@busunkim96 busunkim96 changed the title [CHANGE ME] Re-generated spanner to pick up changes in the API or client library generator. feat(spanner): un-deprecate resource name helper functions, add 3.8 tests (via synth) Jan 8, 2020
@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Jan 8, 2020

Tests failing on docs

Traceback (most recent call last):
  File "/tmpfs/src/github/google-cloud-python/spanner/.nox/docs/lib/python3.7/site-packages/sphinx/cmd/build.py", line 276, in build_main
    app.build(args.force_all, filenames)
  File "/tmpfs/src/github/google-cloud-python/spanner/.nox/docs/lib/python3.7/site-packages/sphinx/application.py", line 353, in build
    self.builder.build_update()
  File "/tmpfs/src/github/google-cloud-python/spanner/.nox/docs/lib/python3.7/site-packages/sphinx/builders/__init__.py", line 299, in build_update
    len(to_build))
  File "/tmpfs/src/github/google-cloud-python/spanner/.nox/docs/lib/python3.7/site-packages/sphinx/builders/__init__.py", line 361, in build
    self.write(docnames, list(updated_docnames), method)
  File "/tmpfs/src/github/google-cloud-python/spanner/.nox/docs/lib/python3.7/site-packages/sphinx/builders/__init__.py", line 535, in write
    self._write_serial(sorted(docnames))
  File "/tmpfs/src/github/google-cloud-python/spanner/.nox/docs/lib/python3.7/site-packages/sphinx/builders/__init__.py", line 545, in _write_serial
    self.write_doc(docname, doctree)
  File "/usr/local/lib/python3.7/contextlib.py", line 119, in __exit__
    next(self.gen)
  File "/tmpfs/src/github/google-cloud-python/spanner/.nox/docs/lib/python3.7/site-packages/sphinx/util/logging.py", line 219, in pending_warnings
    memhandler.flushTo(logger)
  File "/tmpfs/src/github/google-cloud-python/spanner/.nox/docs/lib/python3.7/site-packages/sphinx/util/logging.py", line 184, in flushTo
    logger.handle(record)
  File "/usr/local/lib/python3.7/logging/__init__.py", line 1524, in handle
    self.callHandlers(record)
  File "/usr/local/lib/python3.7/logging/__init__.py", line 1586, in callHandlers
    hdlr.handle(record)
  File "/usr/local/lib/python3.7/logging/__init__.py", line 890, in handle
    rv = self.filter(record)
  File "/usr/local/lib/python3.7/logging/__init__.py", line 751, in filter
    result = f.filter(record)
  File "/tmpfs/src/github/google-cloud-python/spanner/.nox/docs/lib/python3.7/site-packages/sphinx/util/logging.py", line 404, in filter
    raise SphinxWarning(location + ":" + message)
sphinx.errors.SphinxWarning: /tmpfs/src/github/google-cloud-python/spanner/docs/instance-api.rst:11:Could not lex literal_block as "python". Highlighting skipped.```

@busunkim96 busunkim96 added the do not merge label Jan 8, 2020
@busunkim96 busunkim96 merged commit 906e5fa into master Jan 30, 2020
52 checks passed
@busunkim96 busunkim96 deleted the autosynth-spanner branch Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants