Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): add resource based routing implementation #10183

Merged
merged 3 commits into from Jan 31, 2020
Merged

feat(spanner): add resource based routing implementation #10183

merged 3 commits into from Jan 31, 2020

Conversation

larkee
Copy link
Contributor

@larkee larkee commented Jan 23, 2020

Implement resource based routing.

When creating a SpannerClient, check for suggested endpoints.
If endpoints are returned, use the first one.
If no endpoints are returned, use default endpoint (either global endpoint or user-specified endpoint).

Endpoints are cached per instance on the Client.

This feature is disabled by default and is enabled by setting the environment variable to true.

To enable:
export GOOGLE_CLOUD_SPANNER_ENABLE_RESOURCE_BASED_ROUTING=true

@googlebot googlebot added the cla: yes label Jan 23, 2020
@plamut plamut added the api: spanner label Jan 23, 2020
@skuruppu skuruppu requested a review from rhiro Jan 28, 2020
spanner/google/cloud/spanner_v1/database.py Outdated Show resolved Hide resolved
rhiro
rhiro approved these changes Jan 30, 2020
spanner/google/cloud/spanner_v1/database.py Outdated Show resolved Hide resolved
@larkee larkee changed the title Spanner resource routing feat(spanner): add resource based routing implementation Jan 31, 2020
Add comma to warning message

Co-Authored-By: skuruppu <skuruppu@google.com>
@larkee larkee merged commit 193a1dd into googleapis:master Jan 31, 2020
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants