Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigtable Batcher, RowData, Row Operations, AppendRow snippets #7019

Merged
merged 23 commits into from
Mar 14, 2019
Merged

Bigtable Batcher, RowData, Row Operations, AppendRow snippets #7019

merged 23 commits into from
Mar 14, 2019

Conversation

sangramql
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 23, 2018
@sangramql
Copy link
Contributor Author

@tseaver @sduskis @AVaksman
Please review the updated PR.

@tseaver tseaver added api: bigtable Issues related to the Bigtable API. type: docs Improvement to the documentation for an API. labels Jan 3, 2019
crwilcox
crwilcox suggested changes Jan 4, 2019
View reviewed changes
bigtable/docs/snippets_table.py Outdated
row_key = b'row_key_1'
row = table.row(row_key)
row.set_cell(COLUMN_FAMILY_ID,
COL_NAME1,

This comment was marked as spam.

Sign in to view

bigtable/docs/snippets_table.py

batcher.mutate_rows([row1, row2, row3, row4])

# batcher will flush current batch if it

This comment was marked as spam.

Sign in to view

@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Feb 7, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Feb 7, 2019
billyjacobson
billyjacobson reviewed Mar 5, 2019
View reviewed changes
Copy link

@billyjacobson billyjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

bigtable/docs/snippets_table.py Outdated
# Add a single row
row_key = b'row_key'
row = table.row(row_key)
row.set_cell(COLUMN_FAMILY_ID, COL_NAME1, 'value-0')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the value be a byte string?

@crwilcox crwilcox force-pushed the bigtable_batcheroperations_snippets branch from bf2dcbc to 9fd3576 Compare March 8, 2019 18:46
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2019
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2019
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2019
@crwilcox crwilcox mentioned this pull request Mar 12, 2019
Closed
@crwilcox crwilcox changed the title Bigtable Batcher snippets Bigtable Batcher, RowData, Row Operations snippets Mar 12, 2019
@crwilcox crwilcox mentioned this pull request Mar 12, 2019
Closed
@crwilcox crwilcox changed the title Bigtable Batcher, RowData, Row Operations snippets Bigtable Batcher, RowData, Row Operations, AppendRow snippets Mar 12, 2019
@crwilcox crwilcox added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed 🚨 This issue needs some love. labels Mar 12, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 12, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 12, 2019
@crwilcox crwilcox mentioned this pull request Mar 12, 2019
Closed
@crwilcox crwilcox mentioned this pull request Mar 12, 2019
Closed
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 13, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 13, 2019
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 14, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 14, 2019
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 14, 2019
tseaver
tseaver suggested changes Mar 14, 2019
View reviewed changes
bigtable/google/cloud/bigtable/instance.py Outdated Show resolved Hide resolved
bigtable/google/cloud/bigtable/instance.py Outdated Show resolved Hide resolved
bigtable/google/cloud/bigtable/instance.py Outdated Show resolved Hide resolved
bigtable/google/cloud/bigtable/instance.py Outdated Show resolved Hide resolved
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 14, 2019
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 14, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 14, 2019
@crwilcox crwilcox merged commit f242cc1 into googleapis:master Mar 14, 2019
@sethtroisi
Copy link
Contributor

This was super awesome, I was just looking for an AppendRow example, can't wait till these examples go live 👍

@tseaver tseaver mentioned this pull request Jul 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyjacobson billyjacobson billyjacobson left review comments

@crwilcox crwilcox crwilcox requested changes

@tseaver tseaver tseaver requested changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sangramql @sethtroisi @tseaver @crwilcox @billyjacobson @JustinBeckwith @googlebot @yoshi-automation @yoshi-kokoro