Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: async work as functional interface #1068

Merged

Conversation

thiagotnunes
Copy link
Contributor

@thiagotnunes thiagotnunes commented Apr 15, 2021

Marks the async work interface as a functional interface.

This PR also modifies all of its usages to the lambda syntax. Only syntatic changes were made, no logic changes were made here.

Marks the async work interface as a functional interface.
@thiagotnunes thiagotnunes requested a review from as a code owner Apr 15, 2021
@thiagotnunes thiagotnunes requested a review from Apr 15, 2021
@product-auto-label product-auto-label bot added the api: spanner label Apr 15, 2021
@thiagotnunes thiagotnunes requested a review from olavloite Apr 15, 2021
@google-cla google-cla bot added the cla: yes label Apr 15, 2021
@thiagotnunes thiagotnunes requested review from skuruppu and zoercai Apr 15, 2021
@codecov
Copy link

@codecov codecov bot commented Apr 15, 2021

Codecov Report

Merging #1068 (a8cf021) into master (1d4eed4) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1068      +/-   ##
============================================
+ Coverage     85.24%   85.26%   +0.02%     
- Complexity     2658     2661       +3     
============================================
  Files           155      155              
  Lines         14453    14453              
  Branches       1362     1362              
============================================
+ Hits          12320    12324       +4     
+ Misses         1565     1560       -5     
- Partials        568      569       +1     
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/spanner/SessionPoolOptions.java 69.53% <0.00%> (ø) 18.00% <0.00%> (+1.00%)
...ain/java/com/google/cloud/spanner/SessionPool.java 89.12% <0.00%> (+0.19%) 73.00% <0.00%> (+1.00%)
.../google/cloud/spanner/SpannerExceptionFactory.java 89.81% <0.00%> (+1.85%) 49.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d4eed4...a8cf021. Read the comment docs.

@thiagotnunes thiagotnunes merged commit 734fb60 into googleapis:master Apr 15, 2021
18 checks passed
@thiagotnunes thiagotnunes deleted the async-work-functional-interface branch Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants