Skip to content

feat: increase the max length of debug string #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2020
Merged

feat: increase the max length of debug string #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google-cloud-spanner/src/main/java/com/google/cloud/spanner/Value.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public abstract class Value implements Serializable {
*/
public static final Timestamp COMMIT_TIMESTAMP = Timestamp.ofTimeMicroseconds(0L);

private static final int MAX_DEBUG_STRING_LENGTH = 32;
private static final int MAX_DEBUG_STRING_LENGTH = 36;
private static final String ELLIPSIS = "...";
private static final String NULL_STRING = "NULL";
private static final char LIST_SEPERATOR = ',';
Expand Down
6 changes: 3 additions & 3 deletions google-cloud-spanner/src/test/java/com/google/cloud/spanner/ValueTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,11 +212,11 @@ public void stringNull() {

@Test
public void stringLong() {
String str = "aaaaaaaaaabbbbbbbbbbccccccccccdddddddddd";
String str = "aaaaaaaaaabbbbbbbbbbccccccccccddddddddddeee";
Value v = Value.string(str);
assertThat(v.getString()).isEqualTo(str);
assertThat(v.toString()).hasLength(32);
assertThat(v.toString()).startsWith(str.substring(0, 32 - 3));
assertThat(v.toString()).hasLength(36);
assertThat(v.toString()).startsWith(str.substring(0, 36 - 3));
assertThat(v.toString()).endsWith("...");
}

Expand Down