Skip to content

Conversation

skuruppu
Copy link
Contributor

@skuruppu skuruppu commented Jun 25, 2020

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2020
@skuruppu skuruppu marked this pull request as ready for review June 26, 2020 03:05
@skuruppu skuruppu force-pushed the run-presubmits-against-emulator branch from 5deec36 to a541d21 Compare June 26, 2020 03:55
@skuruppu skuruppu requested a review from olavloite June 26, 2020 03:56
@skuruppu skuruppu force-pushed the run-presubmits-against-emulator branch from a541d21 to 997530f Compare June 26, 2020 04:08
@skuruppu skuruppu force-pushed the run-presubmits-against-emulator branch from 997530f to 38b3390 Compare June 26, 2020 04:15
@skuruppu
Copy link
Contributor Author

@olavloite, how do I get the ITs for the connections API running here as well? Or should that be a separate check?

@olavloite
Copy link
Collaborator

@olavloite, how do I get the ITs for the connections API running here as well? Or should that be a separate check?

It seems that the connection API ITs are excluded from the CI builds because they have conflicting categories:

  • The abstract super class of all the ITs have the category IntegrationTest.
  • The concrete sub classes have the category ParallelIntegrationTest

Each category is included and excluded from one of the integration test runs, and as exclusions trump inclusions, these were excluded from all CI runs. See #309 for a fix for this.

@skuruppu
Copy link
Contributor Author

Closing in favor of #310.

@skuruppu skuruppu closed this Jun 29, 2020
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genmgr will
update the corresponding CL at gocloud to depend on the newer version of
go-genproto, and assign reviewers. Whilst this or any regen PR is open in
go-genproto, gapicgen will not create any more regeneration PRs or CLs. If all
regen PRs are closed, gapicgen will create a new set of regeneration PRs and
CLs once per night.

If you have been assigned to review this CL, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
  genmgr to assign reviewers to the gocloud CL.

Corresponding gocloud CL: https://code-review.googlesource.com/c/gocloud/+/51850
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/88a97252-efa1-41f8-87c9-1a1ef3bd41cf/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@3f67cee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants