build: run graalvm integration tests on emulator #3198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
rahul2393
force-pushed
the
run-native-integration-tests-on-emulator
branch
from
83fd7e9 to
d9d913d
Compare
harshachinta
reviewed
Jul 4, 2024
Comment on lines
+53
to
+56
| echo "Starting emulator" | ||
| export SPANNER_EMULATOR_HOST=localhost:9010 | ||
| docker pull gcr.io/cloud-spanner-emulator/emulator | ||
| docker run -d --rm --name spanner-emulator -p 9010:9010 -p 9020:9020 gcr.io/cloud-spanner-emulator/emulator |
There was a problem hiding this comment.
nit: How about moving this with in the switch case below?
Lines 175 to 176 in ade7702
I understand that there will be code duplication. But just thinking that this will give clarity to someone looking at graalvm that it runs on emulator and not real backend.
harshachinta
approved these changes
Jul 4, 2024
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the GraalVM integration tests on the emulator instead of production to speed up builds.