Skip to content

Conversation

varuncnaik
Copy link
Contributor

@varuncnaik varuncnaik commented Jul 23, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@varuncnaik varuncnaik requested a review from a team as a code owner July 23, 2024 00:36
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jul 23, 2024
Copy link

snippet-bot bot commented Jul 23, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Jul 23, 2024
@rahul2393
Copy link
Contributor

@varuncnaik please fix lint,

mvn  com.coveo:fmt-maven-plugin:format

@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2024
@rahul2393 rahul2393 merged commit bc48bf2 into googleapis:main Aug 6, 2024
@varuncnaik varuncnaik deleted the spanner-create-instance-partition branch August 7, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants