Skip to content

chore: unflake ITAsyncAPITest.invalidDatabase #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2024
Merged

chore: unflake ITAsyncAPITest.invalidDatabase #3257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITAsyncAPITest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
import java.util.concurrent.ExecutionException;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.ThreadLocalRandom;
import org.junit.AfterClass;
import org.junit.Before;
import org.junit.BeforeClass;
Expand Down Expand Up @@ -237,17 +238,24 @@ public void invalidDatabase() throws Exception {
RemoteSpannerHelper helper = env.getTestHelper();
DatabaseClient invalidClient =
helper.getClient().getDatabaseClient(DatabaseId.of(helper.getInstanceId(), "invalid"));
ApiFuture<Struct> row =
invalidClient
.singleUse(TimestampBound.strong())
.readRowAsync(TABLE_NAME, Key.of("k99"), ALL_COLUMNS);
Thread.sleep(ThreadLocalRandom.current().nextLong(100L));
try {
// The NOT_FOUND error can come from both the call to invalidClient.singleUse() as well as
// from the call to row.get(), which is why both need to be inside the try block.
ApiFuture<Struct> row =
invalidClient
.singleUse(TimestampBound.strong())
.readRowAsync(TABLE_NAME, Key.of("k99"), ALL_COLUMNS);
row.get();
fail("missing expected exception");
} catch (ExecutionException e) {
assertThat(e.getCause()).isInstanceOf(SpannerException.class);
SpannerException se = (SpannerException) e.getCause();
assertThat(se.getErrorCode()).isEqualTo(ErrorCode.NOT_FOUND);
} catch (ExecutionException | SpannerException thrownException) {
SpannerException spannerException;
if (thrownException instanceof ExecutionException) {
spannerException = (SpannerException) thrownException.getCause();
} else {
spannerException = (SpannerException) thrownException;
}
assertEquals(ErrorCode.NOT_FOUND, spannerException.getErrorCode());
}
}

Expand Down