Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: initialize should be protected #536

Merged
merged 2 commits into from Oct 22, 2020
Merged

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Oct 21, 2020

The AbstractLazyInitializer#initialize() method should be protected.

@olavloite olavloite requested a review from thiagotnunes Oct 21, 2020
@olavloite olavloite requested a review from as a code owner Oct 21, 2020
@google-cla google-cla bot added the cla: yes label Oct 21, 2020
@olavloite
Copy link
Contributor Author

@olavloite olavloite commented Oct 21, 2020

@thiagotnunes It would be good to include this change in the release with the other breaking changes.

@olavloite olavloite requested a review from as a code owner Oct 21, 2020
@codecov
Copy link

@codecov codecov bot commented Oct 21, 2020

Codecov Report

Merging #536 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #536   +/-   ##
=========================================
  Coverage     84.04%   84.04%           
+ Complexity     2540     2537    -3     
=========================================
  Files           140      140           
  Lines         13891    13891           
  Branches       1329     1329           
=========================================
  Hits          11675    11675           
  Misses         1672     1672           
  Partials        544      544           
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/spanner/AbstractLazyInitializer.java 100.00% <ø> (ø) 5.00 <0.00> (ø)
...m/google/cloud/spanner/LazySpannerInitializer.java 50.00% <ø> (ø) 1.00 <0.00> (ø)
.../google/cloud/spanner/SpannerExceptionFactory.java 80.48% <0.00%> (-2.44%) 39.00% <0.00%> (-1.00%)
...om/google/cloud/spanner/TransactionRunnerImpl.java 86.91% <0.00%> (+0.52%) 9.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768c19d...0b24d1c. Read the comment docs.

@thiagotnunes thiagotnunes merged commit 5c4c8c5 into master Oct 22, 2020
21 checks passed
@thiagotnunes thiagotnunes deleted the make-lazy-init-protected branch Oct 22, 2020
@release-please release-please bot mentioned this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants