Skip to content

Commit

Permalink
Merge branch 'copy-backup-2-relevant-changes-only' of https://github.…
Browse files Browse the repository at this point in the history
…com/danieljbruce/nodejs-bigtable into copy-backup-2-relevant-changes-only
  • Loading branch information
danieljbruce committed May 6, 2024
2 parents ff3e603 + 4e49ab7 commit fcae645
Show file tree
Hide file tree
Showing 18 changed files with 431 additions and 94 deletions.
1 change: 0 additions & 1 deletion .kokoro/system-test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions protos/protos.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

53 changes: 48 additions & 5 deletions protos/protos.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 25 additions & 1 deletion protos/protos.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function main(parent) {
};

// Run request
const iterable = await adminClient.listAppProfilesAsync(request);
const iterable = adminClient.listAppProfilesAsync(request);
for await (const response of iterable) {
console.log(response);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ function main(parent) {
};

// Run request
const iterable = await adminClient.listHotTabletsAsync(request);
const iterable = adminClient.listHotTabletsAsync(request);
for await (const response of iterable) {
console.log(response);
}
Expand Down
2 changes: 1 addition & 1 deletion samples/generated/v2/bigtable_table_admin.list_backups.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ function main(parent) {
};

// Run request
const iterable = await adminClient.listBackupsAsync(request);
const iterable = adminClient.listBackupsAsync(request);
for await (const response of iterable) {
console.log(response);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ function main(parent) {
};

// Run request
const iterable = await adminClient.listSnapshotsAsync(request);
const iterable = adminClient.listSnapshotsAsync(request);
for await (const response of iterable) {
console.log(response);
}
Expand Down
2 changes: 1 addition & 1 deletion samples/generated/v2/bigtable_table_admin.list_tables.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ function main(parent) {
};

// Run request
const iterable = await adminClient.listTablesAsync(request);
const iterable = adminClient.listTablesAsync(request);
for await (const response of iterable) {
console.log(response);
}
Expand Down
16 changes: 8 additions & 8 deletions src/row.ts
Original file line number Diff line number Diff line change
Expand Up @@ -705,14 +705,14 @@ export class Row {
!Array.isArray(columnsOrOptionsOrCallback)
? columnsOrOptionsOrCallback
: typeof optionsOrCallback === 'object'
? optionsOrCallback
: {};
? optionsOrCallback
: {};
const callback =
typeof columnsOrOptionsOrCallback === 'function'
? columnsOrOptionsOrCallback
: typeof optionsOrCallback === 'function'
? optionsOrCallback
: cb!;
? optionsOrCallback
: cb!;

let filter;
columns = arrify(columns);
Expand Down Expand Up @@ -864,14 +864,14 @@ export class Row {
typeof valueOrOptionsOrCallback === 'object'
? valueOrOptionsOrCallback
: typeof optionsOrCallback === 'object'
? optionsOrCallback
: {};
? optionsOrCallback
: {};
const callback =
typeof valueOrOptionsOrCallback === 'function'
? valueOrOptionsOrCallback
: typeof optionsOrCallback === 'function'
? optionsOrCallback
: cb!;
? optionsOrCallback
: cb!;

const reqOpts = {
column,
Expand Down
Loading

0 comments on commit fcae645

Please sign in to comment.