fix: retry rst_stream errors #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
src/table.ts
Outdated
| error_message.includes('rst_stream') || | ||
| error_message.includes('rst stream') | ||
| ) { | ||
| return true; |
There was a problem hiding this comment.
I think this might be a bit cleaner:
const error_message = (error.message || '').toLowerCase();
return error.code === 13 && (
error_message.includes('rst_stream') || error_message.includes('rst stream'));
igorbernstein2
approved these changes
Mar 31, 2022
mutianf
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
igorbernstein2
approved these changes
Mar 31, 2022
mutianf
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
mutianf
added
automerge
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
🤖 I have created a release *beep* *boop* --- ## [3.10.0](v3.9.4...v3.10.0) (2022-04-06) ### Features * Add ListHotTablets API method and protobufs ([#1057](#1057)) ([2b175ac](2b175ac)) * AuditConfig for IAM v1 ([#1061](#1061)) ([d1b5f1a](d1b5f1a)) * enable channel pooling ([#1065](#1065)) ([6c3c397](6c3c397)) ### Bug Fixes * disable retry-request, add exponential backoff in mutateRows and readRows ([#1060](#1060)) ([3718011](3718011)) * retry rst_stream errors ([#1059](#1059)) ([90de80f](90de80f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.