test: Add a test configuration for retries #1412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
size: m
danieljbruce
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Github action that intends to verify retries are working. It runs a subset of the conformance tests focused on retries that currently pass. The reason this is important thing is that as we develop, these tests should not suddenly start failing. If they do then we know that we have broken something. Some of the other conformance tests are failing due to other issues with the test proxy and the way those tests interact with some nodejs-bigtable dependencies so these tests are not included in this Github action. More retries tests will be added later.
The reason this Github action became necessary is because the custom mock server written in Node doesn't seem to be interacting properly with google-gax. The mock server in the conformance tests is a much more reliable mock server and so failing tests using this mock server will give us a much better indication that something is wrong with the retry logic.