Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update bigtable grpc service config #747

Merged
merged 2 commits into from
Jun 20, 2020
Merged

feat: update bigtable grpc service config #747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41a5649
Update bigtable grpc service config
yoshi-automation Jun 19, 2020
87e3215
chore: set Ruby namespace in proto options
yoshi-automation Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions protos/google/bigtable/admin/v2/bigtable_instance_admin.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ option java_multiple_files = true;
option java_outer_classname = "BigtableInstanceAdminProto";
option java_package = "com.google.bigtable.admin.v2";
option php_namespace = "Google\\Cloud\\Bigtable\\Admin\\V2";
option ruby_package = "Google::Cloud::Bigtable::Admin::V2";

// Service for creating, configuring, and deleting Cloud Bigtable Instances and
// Clusters. Provides access to the Instance and Cluster schemas only, not the
Expand Down
1 change: 1 addition & 0 deletions protos/google/bigtable/admin/v2/bigtable_table_admin.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ option java_multiple_files = true;
option java_outer_classname = "BigtableTableAdminProto";
option java_package = "com.google.bigtable.admin.v2";
option php_namespace = "Google\\Cloud\\Bigtable\\Admin\\V2";
option ruby_package = "Google::Cloud::Bigtable::Admin::V2";

// Service for creating, configuring, and deleting Cloud Bigtable tables.
//
Expand Down
1 change: 1 addition & 0 deletions protos/google/bigtable/admin/v2/common.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ option java_multiple_files = true;
option java_outer_classname = "CommonProto";
option java_package = "com.google.bigtable.admin.v2";
option php_namespace = "Google\\Cloud\\Bigtable\\Admin\\V2";
option ruby_package = "Google::Cloud::Bigtable::Admin::V2";

// Storage media types for persisting Bigtable data.
enum StorageType {
Expand Down
1 change: 1 addition & 0 deletions protos/google/bigtable/admin/v2/instance.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ option java_multiple_files = true;
option java_outer_classname = "InstanceProto";
option java_package = "com.google.bigtable.admin.v2";
option php_namespace = "Google\\Cloud\\Bigtable\\Admin\\V2";
option ruby_package = "Google::Cloud::Bigtable::Admin::V2";

// A collection of Bigtable [Tables][google.bigtable.admin.v2.Table] and
// the resources that serve them.
Expand Down
1 change: 1 addition & 0 deletions protos/google/bigtable/admin/v2/table.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ option java_multiple_files = true;
option java_outer_classname = "TableProto";
option java_package = "com.google.bigtable.admin.v2";
option php_namespace = "Google\\Cloud\\Bigtable\\Admin\\V2";
option ruby_package = "Google::Cloud::Bigtable::Admin::V2";

// Indicates the type of the restore source.
enum RestoreSourceType {
Expand Down
1 change: 1 addition & 0 deletions protos/google/bigtable/v2/bigtable.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ option java_multiple_files = true;
option java_outer_classname = "BigtableProto";
option java_package = "com.google.bigtable.v2";
option php_namespace = "Google\\Cloud\\Bigtable\\V2";
option ruby_package = "Google::Cloud::Bigtable::V2";
option (google.api.resource_definition) = {
type: "bigtable.googleapis.com/Table"
pattern: "projects/{project}/instances/{instance}/tables/{table}"
Expand Down
1 change: 1 addition & 0 deletions protos/google/bigtable/v2/data.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ option java_multiple_files = true;
option java_outer_classname = "DataProto";
option java_package = "com.google.bigtable.v2";
option php_namespace = "Google\\Cloud\\Bigtable\\V2";
option ruby_package = "Google::Cloud::Bigtable::V2";

// Specifies the complete (requested) contents of a single row of a table.
// Rows which exceed 256MiB in size cannot be read in full.
Expand Down
4 changes: 3 additions & 1 deletion protos/protos.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
"java_multiple_files": true,
"java_outer_classname": "TableProto",
"java_package": "com.google.bigtable.admin.v2",
"php_namespace": "Google\\Cloud\\Bigtable\\Admin\\V2"
"php_namespace": "Google\\Cloud\\Bigtable\\Admin\\V2",
"ruby_package": "Google::Cloud::Bigtable::Admin::V2"
},
"nested": {
"BigtableInstanceAdmin": {
Expand Down Expand Up @@ -1841,6 +1842,7 @@
"java_outer_classname": "DataProto",
"java_package": "com.google.bigtable.v2",
"php_namespace": "Google\\Cloud\\Bigtable\\V2",
"ruby_package": "Google::Cloud::Bigtable::V2",
"(google.api.resource_definition).type": "bigtable.googleapis.com/Table",
"(google.api.resource_definition).pattern": "projects/{project}/instances/{instance}/tables/{table}"
},
Expand Down
18 changes: 9 additions & 9 deletions src/v2/bigtable_client_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,23 +31,23 @@
"methods": {
"ReadRows": {
"timeout_millis": 43200000,
"retry_codes_name": "idempotent",
"retry_params_name": "5af39a0f6db447f61c4f695240caeccb74f78362"
"retry_codes_name": "non_idempotent",
"retry_params_name": "default"
},
"SampleRowKeys": {
"timeout_millis": 20000,
"retry_codes_name": "idempotent",
"retry_params_name": "5af39a0f6db447f61c4f695240caeccb74f78362"
"timeout_millis": 60000,
"retry_codes_name": "non_idempotent",
"retry_params_name": "default"
},
"MutateRow": {
"timeout_millis": 20000,
"timeout_millis": 60000,
"retry_codes_name": "idempotent",
"retry_params_name": "5af39a0f6db447f61c4f695240caeccb74f78362"
},
"MutateRows": {
"timeout_millis": 60000,
"retry_codes_name": "idempotent",
"retry_params_name": "5af39a0f6db447f61c4f695240caeccb74f78362"
"timeout_millis": 600000,
"retry_codes_name": "non_idempotent",
"retry_params_name": "default"
},
"CheckAndMutateRow": {
"timeout_millis": 20000,
Expand Down
6 changes: 3 additions & 3 deletions synth.metadata
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
"git": {
"name": ".",
"remote": "https://github.com/googleapis/nodejs-bigtable.git",
"sha": "508d1f9e0c5b089d7a649eb1dd9e6fc166d17f7e"
"sha": "c6cc3bccf71316af8cf91cc86c1781f6addcdd07"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "a3a0bf0f6291d69f2ff3df7fcd63d28ee20ac727",
"internalRef": "310060413"
"sha": "94fe3637559a257634d7b47a15bb8d976daff788",
"internalRef": "316039767"
}
},
{
Expand Down