Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

fix: make request optional in all cases #9

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion linkinator.config.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"recurse": true,
"skip": [
"https://github.com/googleapis/nodejs-cloud-tpu/blob/master/CHANGELOG.md",
"https://codecov.io/gh/googleapis/",
"www.googleapis.com",
"img.shields.io"
Expand Down
44 changes: 22 additions & 22 deletions src/v1/tpu_client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ export class TpuClient {
// -- Service calls --
// -------------------
getNode(
request: protos.google.cloud.tpu.v1.IGetNodeRequest,
request?: protos.google.cloud.tpu.v1.IGetNodeRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -453,7 +453,7 @@ export class TpuClient {
* const [response] = await client.getNode(request);
*/
getNode(
request: protos.google.cloud.tpu.v1.IGetNodeRequest,
request?: protos.google.cloud.tpu.v1.IGetNodeRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -492,7 +492,7 @@ export class TpuClient {
return this.innerApiCalls.getNode(request, options, callback);
}
getTensorFlowVersion(
request: protos.google.cloud.tpu.v1.IGetTensorFlowVersionRequest,
request?: protos.google.cloud.tpu.v1.IGetTensorFlowVersionRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -540,7 +540,7 @@ export class TpuClient {
* const [response] = await client.getTensorFlowVersion(request);
*/
getTensorFlowVersion(
request: protos.google.cloud.tpu.v1.IGetTensorFlowVersionRequest,
request?: protos.google.cloud.tpu.v1.IGetTensorFlowVersionRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -583,7 +583,7 @@ export class TpuClient {
return this.innerApiCalls.getTensorFlowVersion(request, options, callback);
}
getAcceleratorType(
request: protos.google.cloud.tpu.v1.IGetAcceleratorTypeRequest,
request?: protos.google.cloud.tpu.v1.IGetAcceleratorTypeRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -627,7 +627,7 @@ export class TpuClient {
* const [response] = await client.getAcceleratorType(request);
*/
getAcceleratorType(
request: protos.google.cloud.tpu.v1.IGetAcceleratorTypeRequest,
request?: protos.google.cloud.tpu.v1.IGetAcceleratorTypeRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -669,7 +669,7 @@ export class TpuClient {
}

createNode(
request: protos.google.cloud.tpu.v1.ICreateNodeRequest,
request?: protos.google.cloud.tpu.v1.ICreateNodeRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -729,7 +729,7 @@ export class TpuClient {
* const [response] = await operation.promise();
*/
createNode(
request: protos.google.cloud.tpu.v1.ICreateNodeRequest,
request?: protos.google.cloud.tpu.v1.ICreateNodeRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -814,7 +814,7 @@ export class TpuClient {
>;
}
deleteNode(
request: protos.google.cloud.tpu.v1.IDeleteNodeRequest,
request?: protos.google.cloud.tpu.v1.IDeleteNodeRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -870,7 +870,7 @@ export class TpuClient {
* const [response] = await operation.promise();
*/
deleteNode(
request: protos.google.cloud.tpu.v1.IDeleteNodeRequest,
request?: protos.google.cloud.tpu.v1.IDeleteNodeRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -955,7 +955,7 @@ export class TpuClient {
>;
}
reimageNode(
request: protos.google.cloud.tpu.v1.IReimageNodeRequest,
request?: protos.google.cloud.tpu.v1.IReimageNodeRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -1013,7 +1013,7 @@ export class TpuClient {
* const [response] = await operation.promise();
*/
reimageNode(
request: protos.google.cloud.tpu.v1.IReimageNodeRequest,
request?: protos.google.cloud.tpu.v1.IReimageNodeRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -1098,7 +1098,7 @@ export class TpuClient {
>;
}
stopNode(
request: protos.google.cloud.tpu.v1.IStopNodeRequest,
request?: protos.google.cloud.tpu.v1.IStopNodeRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -1154,7 +1154,7 @@ export class TpuClient {
* const [response] = await operation.promise();
*/
stopNode(
request: protos.google.cloud.tpu.v1.IStopNodeRequest,
request?: protos.google.cloud.tpu.v1.IStopNodeRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -1239,7 +1239,7 @@ export class TpuClient {
>;
}
startNode(
request: protos.google.cloud.tpu.v1.IStartNodeRequest,
request?: protos.google.cloud.tpu.v1.IStartNodeRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -1295,7 +1295,7 @@ export class TpuClient {
* const [response] = await operation.promise();
*/
startNode(
request: protos.google.cloud.tpu.v1.IStartNodeRequest,
request?: protos.google.cloud.tpu.v1.IStartNodeRequest,
optionsOrCallback?:
| CallOptions
| Callback<
Expand Down Expand Up @@ -1380,7 +1380,7 @@ export class TpuClient {
>;
}
listNodes(
request: protos.google.cloud.tpu.v1.IListNodesRequest,
request?: protos.google.cloud.tpu.v1.IListNodesRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -1431,7 +1431,7 @@ export class TpuClient {
* for more details and examples.
*/
listNodes(
request: protos.google.cloud.tpu.v1.IListNodesRequest,
request?: protos.google.cloud.tpu.v1.IListNodesRequest,
optionsOrCallback?:
| CallOptions
| PaginationCallback<
Expand Down Expand Up @@ -1563,7 +1563,7 @@ export class TpuClient {
) as AsyncIterable<protos.google.cloud.tpu.v1.INode>;
}
listTensorFlowVersions(
request: protos.google.cloud.tpu.v1.IListTensorFlowVersionsRequest,
request?: protos.google.cloud.tpu.v1.IListTensorFlowVersionsRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -1622,7 +1622,7 @@ export class TpuClient {
* for more details and examples.
*/
listTensorFlowVersions(
request: protos.google.cloud.tpu.v1.IListTensorFlowVersionsRequest,
request?: protos.google.cloud.tpu.v1.IListTensorFlowVersionsRequest,
optionsOrCallback?:
| CallOptions
| PaginationCallback<
Expand Down Expand Up @@ -1770,7 +1770,7 @@ export class TpuClient {
) as AsyncIterable<protos.google.cloud.tpu.v1.ITensorFlowVersion>;
}
listAcceleratorTypes(
request: protos.google.cloud.tpu.v1.IListAcceleratorTypesRequest,
request?: protos.google.cloud.tpu.v1.IListAcceleratorTypesRequest,
options?: CallOptions
): Promise<
[
Expand Down Expand Up @@ -1829,7 +1829,7 @@ export class TpuClient {
* for more details and examples.
*/
listAcceleratorTypes(
request: protos.google.cloud.tpu.v1.IListAcceleratorTypesRequest,
request?: protos.google.cloud.tpu.v1.IListAcceleratorTypesRequest,
optionsOrCallback?:
| CallOptions
| PaginationCallback<
Expand Down