-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce EntityFilter class with support for and/or filters #1061
Commits on Jan 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d370b54 - Browse repository at this point
Copy the full SHA d370b54View commit details
Commits on Jan 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3291df8 - Browse repository at this point
Copy the full SHA 3291df8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69390d4 - Browse repository at this point
Copy the full SHA 69390d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c90e932 - Browse repository at this point
Copy the full SHA c90e932View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2b29fc - Browse repository at this point
Copy the full SHA c2b29fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69f1cbf - Browse repository at this point
Copy the full SHA 69f1cbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f720c0 - Browse repository at this point
Copy the full SHA 3f720c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20f616b - Browse repository at this point
Copy the full SHA 20f616bView commit details
Commits on Jan 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5dea24a - Browse repository at this point
Copy the full SHA 5dea24aView commit details
Commits on Jan 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bb931e7 - Browse repository at this point
Copy the full SHA bb931e7View commit details
Commits on Jan 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 44be8a9 - Browse repository at this point
Copy the full SHA 44be8a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0055a09 - Browse repository at this point
Copy the full SHA 0055a09View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6bb3b3 - Browse repository at this point
Copy the full SHA b6bb3b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83668a1 - Browse repository at this point
Copy the full SHA 83668a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4fe304 - Browse repository at this point
Copy the full SHA c4fe304View commit details
Commits on Jan 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c397608 - Browse repository at this point
Copy the full SHA c397608View commit details
Commits on Jan 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 37400a6 - Browse repository at this point
Copy the full SHA 37400a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ab6b80 - Browse repository at this point
Copy the full SHA 8ab6b80View commit details
Commits on Jan 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for db02a50 - Browse repository at this point
Copy the full SHA db02a50View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc15f32 - Browse repository at this point
Copy the full SHA bc15f32View commit details
Commits on Feb 7, 2023
-
Adds a new setAncestor method for ensuring only one ancestor is set for the query at a time. This will avoid errors that result because of setting multiple ancestors. Also deprecate hasAncestor because it will lead to warnings like this. Add parser logic to use the value provided in setAncestor for query sent to backend.
Configuration menu - View commit details
-
Copy full SHA for e84582f - Browse repository at this point
Copy the full SHA e84582fView commit details -
Basic unit tests for setAncestor
Added tests for the query proto, one to make sure the query structure is right when setting ancestor once and one to make sure the query structure is right when setting ancestor twice. Also added a unit test to make sure that ancestor is set the right way internally when using setAncestor.
Configuration menu - View commit details
-
Copy full SHA for 86841d6 - Browse repository at this point
Copy the full SHA 86841d6View commit details
Commits on Feb 8, 2023
-
change expected result for OR query
This code change adjusts the expected result for running an OR query. Old result used to correspond with AND, but now corresponds to OR.
Configuration menu - View commit details
-
Copy full SHA for fe50d56 - Browse repository at this point
Copy the full SHA fe50d56View commit details
Commits on Feb 16, 2023
-
Fix a test by not requiring the done callback
A test is timing out because we are waiting for done to be called. This fix does not require done to be called.
Configuration menu - View commit details
-
Copy full SHA for 1159b37 - Browse repository at this point
Copy the full SHA 1159b37View commit details
Commits on Feb 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 49ffcf9 - Browse repository at this point
Copy the full SHA 49ffcf9View commit details
Commits on Feb 24, 2023
-
Merge branch 'main' of https://github.com/googleapis/nodejs-datastore …
…into or-filters # Conflicts: # src/query.ts # test/query.ts
Configuration menu - View commit details
-
Copy full SHA for 3aa7a35 - Browse repository at this point
Copy the full SHA 3aa7a35View commit details
Commits on Feb 27, 2023
-
Revert "Fix a test by not requiring the done callback"
This reverts commit 1159b37.
Configuration menu - View commit details
-
Copy full SHA for a7a8d27 - Browse repository at this point
Copy the full SHA a7a8d27View commit details -
Revert "Basic unit tests for setAncestor"
This reverts commit 86841d6.
Configuration menu - View commit details
-
Copy full SHA for 1c77b6c - Browse repository at this point
Copy the full SHA 1c77b6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f38179 - Browse repository at this point
Copy the full SHA 5f38179View commit details -
Separate filters and new filters internally
This commit is done to avoid a breaking typescript change which could have the potential to affect some users who read `filters` on a query as its type had been changed to be more flexible, but is now back to what it was.
Configuration menu - View commit details
-
Copy full SHA for 059d4dc - Browse repository at this point
Copy the full SHA 059d4dcView commit details
Commits on Mar 1, 2023
-
Move AND/OR into their own separate function
AND and OR should not be static functions of the filter class because then the user has to type Filter.AND instead of AND for example.
Configuration menu - View commit details
-
Copy full SHA for ec752e8 - Browse repository at this point
Copy the full SHA ec752e8View commit details -
Artifacts of having imports laying around and moving functionality between files
Configuration menu - View commit details
-
Copy full SHA for a5c41ab - Browse repository at this point
Copy the full SHA a5c41abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ddeea6 - Browse repository at this point
Copy the full SHA 1ddeea6View commit details -
Revert "Now removes deprecation warning properly"
This reverts commit db02a50.
Configuration menu - View commit details
-
Copy full SHA for 8e96bf5 - Browse repository at this point
Copy the full SHA 8e96bf5View commit details
Commits on Mar 7, 2023
-
Modify test cases to capture nuances in data
We add additional asserts to the data in order to capture the nuances of the composite operator. For example, for the OR test we make sure the filter doesn’t always require both conditions to be true.
Configuration menu - View commit details
-
Copy full SHA for 5883096 - Browse repository at this point
Copy the full SHA 5883096View commit details -
Added comments to code that was refactored
Code for building the `filter` property of the query proto was pulled into the `Filter` object. Comments indicate how legacy functionality was maintained and which lines of code perform which task.
Configuration menu - View commit details
-
Copy full SHA for 0a68ed1 - Browse repository at this point
Copy the full SHA 0a68ed1View commit details -
rename NewFilter to entity filter
rename new filter to entity filter to eliminate the need for an internal rename that causes confusion
Configuration menu - View commit details
-
Copy full SHA for 35bae06 - Browse repository at this point
Copy the full SHA 35bae06View commit details -
These test cases have mistakes in their names. We should change them to reflect the position of `hasAncestor`.
Configuration menu - View commit details
-
Copy full SHA for 262894a - Browse repository at this point
Copy the full SHA 262894aView commit details
Commits on Mar 8, 2023
-
Change the comment to reflect the new name
The name of the base class is now EntityFilter. Adjust this comment so that it correctly matches the parameter type.
Configuration menu - View commit details
-
Copy full SHA for 30c3832 - Browse repository at this point
Copy the full SHA 30c3832View commit details -
rename and move constant map up
rename composite filter functions so that they don’t look like constants and move a map up so that it doesn’t have to be initialized every time.
Configuration menu - View commit details
-
Copy full SHA for fa2235d - Browse repository at this point
Copy the full SHA fa2235dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e7f9d5 - Browse repository at this point
Copy the full SHA 4e7f9d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c72fcc9 - Browse repository at this point
Copy the full SHA c72fcc9View commit details