Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Firebase Version to header #414

Merged
merged 9 commits into from
Nov 2, 2018
Merged

Add Firebase Version to header #414

merged 9 commits into from
Nov 2, 2018

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Oct 23, 2018 •
edited
Loading

This PR allows the Admin SDK to pass its version to our SDK. We then add it as a header value to the existing x-goog-api-client header.

This looks like this:

x-goog-api-client: gl-node/v8.11.3 grpc/1.15.1 gax/0.20.0 gapic/0.18.0 gccl/0.18.0 fire/6.1.0

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 23, 2018
Feiyang1
Feiyang1 reviewed Oct 24, 2018
View reviewed changes
dev/src/index.ts
};

if (settings && settings.firebaseVersion) {
libraryHeader.libVersion += ' fire/' + settings.firebaseVersion;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Feiyang1
Feiyang1 reviewed Oct 24, 2018
View reviewed changes
dev/src/index.ts
@@ -279,11 +279,6 @@ export class Firestore {
* use `Timestamp` now and opt-in to this new behavior as soon as you can.
*/
constructor(settings?: Settings) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@schmidt-sebastian
Copy link
Contributor Author

Ping :)

@alexander-fenster
Copy link
Contributor

It looks the code will add fire/x.x.x, not firebase/x.x.x as the description states. LGTM if that's expected. If you can create an issue for googleapis/gapic-generator to have better support for multiple library-version pairs, it would be great.

@alexander-fenster alexander-fenster self-requested a review November 2, 2018 19:53
@schmidt-sebastian
Copy link
Contributor Author

It looks the code will add fire/x.x.x, not firebase/x.x.x as the description states. LGTM if that's expected. If you can create an issue for googleapis/gapic-generator to have better support for multiple library-version pairs, it would be great.

We updated the code to use fire/. I changed the description to match this.

Issue: https://github.com/googleapis/gapic-generator/issues/2400

@schmidt-sebastian schmidt-sebastian merged commit 9a2f450 into master Nov 2, 2018
@jmdobry jmdobry deleted the mrschmidt-firebaseheader branch December 5, 2018 07:07
@schmidt-sebastian schmidt-sebastian mentioned this pull request Apr 9, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Feiyang1 Feiyang1 Feiyang1 left review comments

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Assignees

@JustinBeckwith JustinBeckwith

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@schmidt-sebastian @alexander-fenster @Feiyang1 @JustinBeckwith @googlebot