fix: run synthtool hack to compile code #6
Conversation
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
=======================================
Coverage 97.17% 97.17%
=======================================
Files 5 5
Lines 1841 1841
Branches 83 83
=======================================
Hits 1789 1789
Misses 51 51
Partials 1 1 Continue to review full report at Codecov.
|
| s.replace('src/v1/cloud_functions_service_client.ts', "function:string", "function_: string") | ||
| s.replace('src/v1/cloud_functions_service_client.ts', "function: function", "function: function_") |
There was a problem hiding this comment.
Do we plan to have this in perpetuity or is this something the generator should be able to handle? For any substantive synthtool replacements, we should have a bug filed on the upstream generator or team (and comment here with the link) so that these clients can generate without synthtool hacks.
There was a problem hiding this comment.
Yes! Alex F. is working on it. We discussed it in our Node meeting yesterday. He asked me to implement this hack in the meantime, as it might take some weeks to work.
There was a problem hiding this comment.
sofisl
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
No description provided.