Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

docs(samples): Add Game Server deployment samples #92

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented Jul 15, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #91 🦕

@pooneh-m pooneh-m requested a review from a team as a code owner July 15, 2020 22:10
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2020
@pooneh-m
Copy link
Contributor Author

@Laremere please take a look.

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #92 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files           8        8           
  Lines        6749     6749           
  Branches      272      264    -8     
=======================================
  Hits         6627     6627           
  Misses        118      118           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8870727...ae84677. Read the comment docs.

samples/README.md Show resolved Hide resolved
samples/create_deployment.js Outdated Show resolved Hide resolved
samples/create_deployment.js Outdated Show resolved Hide resolved
samples/delete_deployment.js Outdated Show resolved Hide resolved
samples/delete_deployment.js Outdated Show resolved Hide resolved
samples/test/crud_deployment.test.js Outdated Show resolved Hide resolved
@JustinBeckwith
Copy link
Contributor

👋 for the lint issue, should be able to run npm run fix from the root

Copy link
Contributor Author

@pooneh-m pooneh-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I had some clarification questions, since this is the first time I am contributing to this repo.

samples/delete_deployment.js Outdated Show resolved Hide resolved
@pooneh-m pooneh-m force-pushed the master branch 2 times, most recently from ec2eb71 to e3d38cd Compare July 15, 2020 23:58
@Laremere
Copy link

samples/create_cluster.js Outdated Show resolved Hide resolved
@pooneh-m pooneh-m force-pushed the master branch 3 times, most recently from 3b107ec to 0758319 Compare July 16, 2020 15:57
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for sticking with the feedback.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2020
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2020
@JustinBeckwith JustinBeckwith changed the title Add Game Server deployment samples docs(samples): Add Game Server deployment samples Jul 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2020
@JustinBeckwith JustinBeckwith merged commit d439b73 into googleapis:master Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add samples for GameServerDeployment
6 participants