-
Notifications
You must be signed in to change notification settings - Fork 7
docs(samples): Add Game Server deployment samples #92
Conversation
@Laremere please take a look. |
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
=======================================
Coverage 98.19% 98.19%
=======================================
Files 8 8
Lines 6749 6749
Branches 272 264 -8
=======================================
Hits 6627 6627
Misses 118 118
Partials 4 4 Continue to review full report at Codecov.
|
👋 for the lint issue, should be able to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I had some clarification questions, since this is the first time I am contributing to this repo.
ec2eb71
to
e3d38cd
Compare
FYI, canonical examples: https://github.com/GoogleCloudPlatform/golang-samples/tree/master/gaming/servers |
3b107ec
to
0758319
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for sticking with the feedback.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #91 🦕